Skip to content

Commit

Permalink
Add attribute to specify polling timeout for exp_check_for_ready
Browse files Browse the repository at this point in the history
Change-Id: I2ab3384927c89c8aa8f8c16f2b7a666c5f1ae935
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/89027
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Dev-Ready: STEPHEN GLANCY <sglancy@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Mark Pizzutillo <mark.pizzutillo@ibm.com>
Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com>
Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com>
Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/89050
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
  • Loading branch information
stermole authored and crgeddes committed Jan 9, 2020
1 parent 6b24abd commit 7b91b95
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 3 deletions.
Expand Up @@ -5,7 +5,7 @@
/* */
/* OpenPOWER HostBoot Project */
/* */
/* Contributors Listed Below - COPYRIGHT 2018,2019 */
/* Contributors Listed Below - COPYRIGHT 2018,2020 */
/* [+] International Business Machines Corp. */
/* */
/* */
Expand Down Expand Up @@ -38,6 +38,8 @@
#include <exp_check_for_ready.H>
#include <lib/i2c/exp_i2c.H>
#include <generic/memory/mss_git_data_helper.H>
#include <generic/memory/lib/utils/shared/mss_generic_consts.H>
#include <mss_explorer_attribute_getters.H>

extern "C"
{
Expand All @@ -50,7 +52,11 @@ extern "C"
{
mss::display_git_commit_info("exp_check_for_ready");

FAPI_TRY(mss::exp::i2c::exp_check_for_ready_helper(i_target));
fapi2::ATTR_MSS_CHECK_FOR_READY_TIMEOUT_Type l_poll_count = 0;

FAPI_TRY(mss::attr::get_check_for_ready_timeout(i_target, l_poll_count));

FAPI_TRY(mss::exp::i2c::exp_check_for_ready_helper(i_target, l_poll_count, mss::DELAY_1MS));

fapi_try_exit:
return fapi2::current_err;
Expand Down
Expand Up @@ -5,7 +5,7 @@
<!-- -->
<!-- OpenPOWER HostBoot Project -->
<!-- -->
<!-- Contributors Listed Below - COPYRIGHT 2018,2019 -->
<!-- Contributors Listed Below - COPYRIGHT 2018,2020 -->
<!-- [+] International Business Machines Corp. -->
<!-- -->
<!-- -->
Expand Down Expand Up @@ -473,4 +473,18 @@
<mrwHide/>
</attribute>

<attribute>
<id>ATTR_MSS_CHECK_FOR_READY_TIMEOUT</id>
<targetType>TARGET_TYPE_OCMB_CHIP</targetType>
<description>
Timeout (in msec) for polling for FW_STATUS reply during
exp_check_for_ready. Default is 400msec, from lab experimentation
</description>
<valueType>uint16</valueType>
<default>400</default>
<platInit/>
<mrwHide/>
<mssAccessorName>check_for_ready_timeout</mssAccessorName>
</attribute>

</attributes>

0 comments on commit 7b91b95

Please sign in to comment.