Skip to content

Commit

Permalink
Remove call to retrieve data from a previous runtime crash
Browse files Browse the repository at this point in the history
The reserved trace buffer is storing pointers that are no longer
valid after opal-prd is restarted.

Change-Id: I2495a2ca57e498aee571edc87e868ebd635d6df5
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/72580
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
cvswen authored and dcrowell77 committed Feb 28, 2019
1 parent 7c0b8df commit 80cea86
Showing 1 changed file with 9 additions and 5 deletions.
14 changes: 9 additions & 5 deletions src/usr/trace/runtime/rt_rsvdtracebufservice.C
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
/* */
/* OpenPOWER HostBoot Project */
/* */
/* Contributors Listed Below - COPYRIGHT 2013,2018 */
/* Contributors Listed Below - COPYRIGHT 2013,2019 */
/* [+] International Business Machines Corp. */
/* */
/* */
Expand Down Expand Up @@ -73,13 +73,17 @@ void RsvdTraceBufService::init()
l_reservedMemory + sizeof(uintptr_t),
l_addressToHead);

//----------
// There is a problem with saving pointers in the trace entry
// Removing this temporarily until a solution is found
//----------
// If the data is not NULL, then retrieve crashed data
// I want NULL in this case, not nullptr; *l_addressToHead is an int.
// If I use nullptr; compiler complains
if (*l_addressToHead != NULL)
{
retrieveDataFromLastCrash();
}
//if (*l_addressToHead != NULL)
//{
// retrieveDataFromLastCrash();
//}

// After gathering trace info from previous crash, clear buffer data
iv_rsvdTraceBuffer.clearBuffer();
Expand Down

0 comments on commit 80cea86

Please sign in to comment.