Skip to content

Commit

Permalink
Enable IPMI errl after targeting is initialized
Browse files Browse the repository at this point in the history
A recent change split IPMI into base and extended.
Move the enable of IPMI errl from base to extended
to avoid targeting errors.

Change-Id: Ia833dd8178ff407dff1fa514b32468c5fc70e945
CQ:SW450286
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/68265
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: ANDREW R. JEFFERY <andrewrj@au1.ibm.com>
Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
cvswen authored and dcrowell77 committed Nov 5, 2018
1 parent b26e6d8 commit 83335d5
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 3 deletions.
6 changes: 6 additions & 0 deletions src/include/usr/ipmi/ipmisel.H
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,12 @@ class IpmiSEL
*/
~IpmiSEL(void);

/**
* Enable ipmi errl
* @param[in] o_errl, NULL if OK
*/
static void errlEnable(errlHndl_t& o_errl);

/**
* @brief Get the message queue associated with this FRU
* @param[in] void
Expand Down
3 changes: 0 additions & 3 deletions src/usr/ipmibase/ipmirp.C
Original file line number Diff line number Diff line change
Expand Up @@ -574,9 +574,6 @@ void IpmiRP::execute(void)
// Wait for an event message read it and handle it if no one else does
task_create( &IpmiRP::last_chance_event_handler, NULL);

// call ErrlManager function - tell him that IPMI is ready!
ERRORLOG::ErrlManager::errlResourceReady(ERRORLOG::IPMI);

while (true)
{

Expand Down
14 changes: 14 additions & 0 deletions src/usr/ipmiext/ipmisel.C
Original file line number Diff line number Diff line change
Expand Up @@ -592,5 +592,19 @@ void IpmiSEL::execute(void)
IPMI_TRAC(EXIT_MRK "message loop");
return;
} // execute


/*
* @brief enable IPMI errl
*/
void IpmiSEL::errlEnable(errlHndl_t& o_errl)
{
// call ErrlManager function - tell him that IPMI is ready!
ERRORLOG::ErrlManager::errlResourceReady(ERRORLOG::IPMI);
}

TASK_ENTRY_MACRO( IpmiSEL::errlEnable );


#endif

0 comments on commit 83335d5

Please sign in to comment.