Skip to content

Commit

Permalink
Add retry loop to UCD deviceOps
Browse files Browse the repository at this point in the history
The UCD requirements say that if a device operation fails to attempt a
total of three times before giving up. This commit adds that
functionality. Each deviceOp is attempted three times with the addition
of the attemptDeviceOp function.

Change-Id: I03874f66465960c672026fb42a8719e6b6aad7ec
RTC:205982
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/75109
Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com>
Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
MRaybuck authored and dcrowell77 committed Mar 29, 2019
1 parent 0d9e3f2 commit 8684bd3
Show file tree
Hide file tree
Showing 2 changed files with 344 additions and 71 deletions.
2 changes: 2 additions & 0 deletions src/include/usr/ucd/ucd_reasoncodes.H
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ namespace UCD_RC
MOD_UPDATE_ALL_UCD_FLASH_IMAGES = 0x02,
MOD_UPDATE_UCD_FLASH_IMAGE = 0x03,
MOD_VERIFY_UPDATE = 0x04,
MOD_PERFORM_DEVICE_OP = 0x05,
};

enum UcdReasonCode
Expand All @@ -51,6 +52,7 @@ namespace UCD_RC
UCD_INVALID_COMMANDLINE = UCD_COMP_ID | 0x09,
UCD_ERROR_STORING_TO_FLASH = UCD_COMP_ID | 0x0A,
UCD_TIMEDOUT_STORING_TO_FLASH = UCD_COMP_ID | 0x0B,
UCD_INVALID_DEVICE_OP = UCD_COMP_ID | 0x0C,
};

}; // namespace UCD
Expand Down

0 comments on commit 8684bd3

Please sign in to comment.