Skip to content

Commit

Permalink
Convert mss explorer and axone code to use attr accessors
Browse files Browse the repository at this point in the history
  Add more xml files to accessor generator makefiles
  Also fix const param errors in attr setter functions

Change-Id: I4f30451d92b767cc380005a586e95aafc4771f50
Original-Change-Id: I178ee5c420cf6f9f8bae61a6ad80bdaea81e231f
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/69954
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com>
Reviewed-by: ANDRE A. MARIN <aamarin@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/71832
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
  • Loading branch information
stermole authored and crgeddes committed Feb 14, 2019
1 parent 5aa25ac commit 8928ba6
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions src/import/generic/memory/tools/gen_accessors.pm
Original file line number Diff line number Diff line change
Expand Up @@ -198,17 +198,16 @@ sub create_params_doxy
}
$g_parameter->{headerString} .=
" /// \@param[out] $attr->{valueType}_t&[] array reference to store the value\n";
$s_parameter->{headerString} .=
" /// \@param[in] $attr->{valueType}_t&[] const ref to array of values to set\n";
$g_parameter->{subString} .= "$attr->{valueType}_t (&o_array)$dims";
$s_parameter->{subString} .= "const $attr->{valueType}_t (&i_array)$dims";
$s_parameter->{headerString} .= " /// \@param[in] $attr->{valueType}_t&[] ref to array of values to set\n";
$g_parameter->{subString} .= "$attr->{valueType}_t (&o_array)$dims";
$s_parameter->{subString} .= "$attr->{valueType}_t (&i_array)$dims";
}
else
{
$g_parameter->{headerString} .= " /// \@param[out] $attr->{valueType}_t& reference to store the value\n";
$s_parameter->{headerString} .= " /// \@param[in] $attr->{valueType}_t the value to set\n";
$g_parameter->{subString} .= "$attr->{valueType}_t& o_value";
$s_parameter->{subString} .= "const $attr->{valueType}_t i_value";
$s_parameter->{subString} .= "$attr->{valueType}_t i_value";
}

$g_parameter->{headerString} .= " /// \@note Generated by gen_accessors.pl $subroutine_name\n";
Expand Down

0 comments on commit 8928ba6

Please sign in to comment.