Dram Repairs and Row Repair VPD translation trace

Change-Id: I68aeb1d0be220f25b3a6ea055d9de21bf6b439d3 RTC: 199027 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/69014 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Brian J. Stegmiller <bjs@us.ibm.com> Reviewed-by: Zane C. Shelley <zshelle@us.ibm.com>
open-power · Dec 4, 2018 · 8c45251 · 8c45251
1 parent 8dec4a4
commit 8c45251
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/src/usr/fapi2/attribute_service.C b/src/usr/fapi2/attribute_service.C
@@ -1198,6 +1198,10 @@ ReturnCode __badDqBitTranslation( const Target<TARGET_TYPE_DIMM>& i_fapiDimm,
                             FAPI_TRY( __mcLogicalToDimmDqHelper(i_fapiDimm,
                                       i_wiringData, i_ps, l_pin,
                                       l_translatedPin) );
+                            FAPI_INF( "__badDqBitTranslation: Bad bit set, "
+                                      "rank:%d before translation:%d, after "
+                                      "translation:%d", rank, l_pin,
+                                      l_translatedPin );
                         }
                         else
                         {
@@ -1682,6 +1686,13 @@ ReturnCode __rowRepairTranslateDramPos(
         uint8_t l_translatedDram = 0;
         FAPI_TRY( __dqToDram(i_fapiDimm, l_translatedDq, l_translatedDram) );
 
+        if ( i_mcLogicalToDimmDq )
+        {
+            FAPI_INF( "__rowRepairTranslateDramPos: Row repair set, rank:%d "
+                      "dram pos before translation:%d, after translation:%d",
+                      rank, l_dramPos, l_translatedDram );
+        }
+
         uint8_t l_updatedData = (l_translatedDram << 3) | l_srank;
 
         io_translatedData[rank][0] = l_updatedData;

diff --git a/src/usr/fapi2/dimmBadDqBitmapFuncs.C b/src/usr/fapi2/dimmBadDqBitmapFuncs.C
@@ -127,6 +127,7 @@ fapi2::ReturnCode dimmBadDqCheckParamGetBitmap( const fapi2::Target
         }
         else
         {
+            // TODO RTC 201603 - axone/generic updates
             // Invalid target.
             FAPI_ERR( "dimmBadDqCheckParamGetBitmap: Invalid proc model" );
             l_rc = fapi2::FAPI2_RC_INVALID_ATTR_GET;