Skip to content

Commit

Permalink
PRD: remove assert for debug purposes
Browse files Browse the repository at this point in the history
Change-Id: I2db9d5868e7f38f06719c0c47850032bd10ef298
CQ: SW400798
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/45531
Reviewed-by: Benjamin J. Weisenbeck <bweisenb@us.ibm.com>
Reviewed-by: Brian J. Stegmiller <bjs@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Zane C. Shelley <zshelle@us.ibm.com>
  • Loading branch information
zane131 committed Sep 1, 2017
1 parent 82ce429 commit 8f46646
Showing 1 changed file with 19 additions and 6 deletions.
25 changes: 19 additions & 6 deletions src/usr/diag/prdf/plat/mem/prdfMemTdCtlr.C
Expand Up @@ -67,7 +67,17 @@ uint32_t MemTdCtlr<T>::handleCmdComplete( STEP_CODE_DATA_STRUCT & io_sc )

#else // IPL only

PRDF_ASSERT( isInMdiaMode() ); // MDIA must be running.
// TODO: RTC 179251 asserting here doesn't give us enough FFDC to debug
// why we got this erroneous attention. Eventually, we will want
// to add the capture data to the assert error log. Until then
// exit with a bad RC and make the error log predictive.
// PRDF_ASSERT( isInMdiaMode() ); // MDIA must be running.
if ( !isInMdiaMode() )
{
PRDF_ERR( PRDF_FUNC "IPL cmd complete attn outside of MDIA" );
o_rc = FAIL;
break;
}

// Inform MDIA the command has completed and PRD is starting analysis.
o_rc = mdiaSendEventMsg( iv_chip->getTrgt(), MDIA::RESET_TIMER );
Expand Down Expand Up @@ -137,11 +147,14 @@ uint32_t MemTdCtlr<T>::handleCmdComplete( STEP_CODE_DATA_STRUCT & io_sc )

#ifndef __HOSTBOOT_RUNTIME // IPL only

// Tell MDIA to skip further analysis on this target.
uint32_t l_rc = mdiaSendEventMsg( iv_chip->getTrgt(),
MDIA::STOP_TESTING );
if ( SUCCESS != l_rc )
PRDF_ERR( PRDF_FUNC "mdiaSendEventMsg(STOP_TESTING) failed" );
if ( isInMdiaMode() )
{
// Tell MDIA to skip further analysis on this target.
uint32_t l_rc = mdiaSendEventMsg( iv_chip->getTrgt(),
MDIA::STOP_TESTING );
if ( SUCCESS != l_rc )
PRDF_ERR( PRDF_FUNC "mdiaSendEventMsg(STOP_TESTING) failed" );
}

#endif
}
Expand Down

0 comments on commit 8f46646

Please sign in to comment.