Skip to content

Commit

Permalink
Skip call to FSP for runtime deconfigs if there is no FSP
Browse files Browse the repository at this point in the history
HBRT sends a message to the FSP when a runtime deconfig takes
place.  Obviously if there is no FSP present we shouldn't send
that message.

Change-Id: I6b778b3b54d30612585b2718b17b33d4a60a7407
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/62143
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Corey V. Swenson <cswenson@us.ibm.com>
Reviewed-by: Roland Veloz <rveloz@us.ibm.com>
Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
  • Loading branch information
dcrowell77 authored and wghoffa committed Jul 24, 2018
1 parent d1c85ff commit 8f9c605
Showing 1 changed file with 10 additions and 2 deletions.
12 changes: 10 additions & 2 deletions src/usr/hwas/hwasPlatDeconfigGard.C
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
#include <sys/mm.h>
#include <config.h>
#include <initservice/istepdispatcherif.H>
#include <initservice/initserviceif.H>

#include <pnor/pnorif.H>

Expand Down Expand Up @@ -593,6 +594,13 @@ void DeconfigGard::platPostDeconfigureTarget(

do
{
// This path is only relevant for FSP systems
if( !INITSERVICE::spBaseServicesEnabled() )
{
break;
}

// Make sure we have all of our function pointers setup right
if ((nullptr == g_hostInterfaces) ||
(nullptr == g_hostInterfaces->firmware_request))
{
Expand All @@ -612,7 +620,7 @@ void DeconfigGard::platPostDeconfigureTarget(
HWAS::RC_RT_NULL_FIRMWARE_REQUEST_PTR,
get_huid(i_pTarget),
0,
true);
ErrlEntry::ADD_SW_CALLOUT);
break;
}

Expand Down Expand Up @@ -648,7 +656,7 @@ void DeconfigGard::platPostDeconfigureTarget(
HWAS::RC_RT_NULL_FIRMWARE_MSG_PTR,
get_huid(i_pTarget),
0,
true);
ErrlEntry::ADD_SW_CALLOUT);
break;
}

Expand Down

0 comments on commit 8f9c605

Please sign in to comment.