Skip to content

Commit

Permalink
p9_fab_iovalid -- enhance half-link fail determination
Browse files Browse the repository at this point in the history 
Change-Id: If85c999f2f2fa24115ba4246a974b2232d0796c2
CQ: SW441210
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/64354
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com>
Reviewed-by: DANIEL C. HOWE <dchowe@us.ibm.com>
Reviewed-by: Thi N. Tran <thi@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/64357
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
@jjmcgill @dcrowell77
jjmcgill authored and dcrowell77 committed Aug 20, 2018
1 parent 70e60e2 commit 9a96890
Showing 1 changed file with 16 additions and 7 deletions.
23 changes: 16 additions & 7 deletions src/import/chips/p9/procedures/hwp/nest/p9_fab_iovalid.C
View file
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,7 @@ fapi2::ReturnCode p9_fab_iovalid_lane_validate(
FAPI_DBG("Non zero lane fail/not locked count: %d %d",
l_lane_failed_count, l_lane_not_locked_count);

if ((l_lane_failed_count == 1) && (l_lane_not_locked_count == 1))
if ((l_lane_failed_count <= 1) && (l_lane_not_locked_count <= 1))
{
if (i_even_not_odd)
{
Expand Down Expand Up @@ -649,8 +649,10 @@ fapi2::ReturnCode p9_fab_iovalid_link_validate(

if (!l_dl_trained)
{
l_dl_fail_even = !((l_dl_status_even == 0x8) && ((l_dl_status_odd >= 0xB) && (l_dl_status_odd <= 0xE)));
l_dl_fail_odd = !((l_dl_status_odd == 0x8) && ((l_dl_status_even >= 0xB) && (l_dl_status_even <= 0xE)));
l_dl_fail_even = !(((l_dl_status_even == 0x8) && ((l_dl_status_odd >= 0xB) && (l_dl_status_odd <= 0xE))) ||
((l_dl_status_even == 0x2) && ((l_dl_status_odd >= 0x8) && (l_dl_status_odd <= 0x9))));
l_dl_fail_odd = !(((l_dl_status_odd == 0x8) && ((l_dl_status_even >= 0xB) && (l_dl_status_even <= 0xE))) ||
((l_dl_status_odd == 0x2) && ((l_dl_status_even >= 0x8) && (l_dl_status_even <= 0x9))));
}
}
else if (l_loc_link_train == fapi2::ENUM_ATTR_LINK_TRAIN_EVEN_ONLY)
Expand Down Expand Up @@ -683,7 +685,7 @@ fapi2::ReturnCode p9_fab_iovalid_link_validate(
// spare has been consumed (MFG may choose to fail based on this criteria)
//
// if more than one spare is detected, mark the link as failed
if (T == fapi2::TARGET_TYPE_OBUS)
if (l_dl_trained && (T == fapi2::TARGET_TYPE_OBUS))
{
bool l_dl_fail_by_lane_status = false;
FAPI_DBG("OBUS - Checking for DL lane failures");
Expand Down Expand Up @@ -732,18 +734,25 @@ fapi2::ReturnCode p9_fab_iovalid_link_validate(
l_dl_fail_even,
l_dl_fail_odd);

// retrain on half link, only if:
// - tried to train in full width mdoe
// - exactly one half reported good & one half reported bad
if ((l_loc_link_train == fapi2::ENUM_ATTR_LINK_TRAIN_BOTH) &&
((l_dl_fail_even != true) || (l_dl_fail_odd != true)) &&
(T == fapi2::TARGET_TYPE_OBUS))
(T == fapi2::TARGET_TYPE_OBUS) &&
((l_dl_fail_even && !l_dl_fail_odd) ||
(!l_dl_fail_even && l_dl_fail_odd)))
{
// setup to retrain half link only
l_loc_link_train_next = (l_dl_fail_even) ?
(fapi2::ENUM_ATTR_LINK_TRAIN_ODD_ONLY) :
(fapi2::ENUM_ATTR_LINK_TRAIN_EVEN_ONLY);

FAPI_DBG("Setting up to retrain with ATTR_LINK_TRAIN: 0x%x",
l_loc_link_train_next);
}
// otherwise, no retraining will be attempted:
// - tried to train only half-width, and were not successful
// - tried to train full-width, and both links were detected
// to be failed (or passed, should only result from code issue)
else
{
l_loc_link_train_next = fapi2::ENUM_ATTR_LINK_TRAIN_NONE;
Expand Down

0 comments on commit 9a96890

Please sign in to comment.