Skip to content

Commit

Permalink
Attribute cleanup
Browse files Browse the repository at this point in the history
Added mrwHide to a lot of platInit attributes, this will prevent
 them from showing up in the ServerWiz tool where the value will
 be hard to change.  Instead these will always rely on the default
 in the xml or explicit platform code to set.
Also removed a bunch of unused tags to clean things up.

Change-Id: Id237924d737392368c418cc31d6506f1f5598b98
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/64233
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com>
Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Joseph J. McGill <jmcgill@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/66015
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
dcrowell77 committed Sep 27, 2018
1 parent a291da7 commit 9d54c3e
Show file tree
Hide file tree
Showing 13 changed files with 99 additions and 1,031 deletions.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,6 @@
<description>MBA DRAM data bus utilization percent to use to determine cfg_nm_n_per_mba</description>
<valueType>uint8</valueType>
<writeable/>
<odmVisable/>
<odmChangeable/>
<persistRuntime/>
</attribute>

<!--
Expand All @@ -53,9 +50,6 @@
<description>cfg_nm_n_per_mba throttle N value calculated from ATTR_CEN_MSS_DATABUS_UTIL_PER_MBA</description>
<valueType>uint32</valueType>
<writeable/>
<odmVisable/>
<odmChangeable/>
<persistRuntime/>
</attribute>
-->

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<!-- -->
<!-- OpenPOWER HostBoot Project -->
<!-- -->
<!-- Contributors Listed Below - COPYRIGHT 2016,2017 -->
<!-- Contributors Listed Below - COPYRIGHT 2016,2018 -->
<!-- [+] International Business Machines Corp. -->
<!-- -->
<!-- -->
Expand Down Expand Up @@ -42,7 +42,6 @@
<description>Can choose mcbist address mode for full,half or quarter addressing mode.</description>
<valueType>uint8</valueType>
<writeable/>
<odmVisable/>
</attribute>

<attribute>
Expand All @@ -51,7 +50,6 @@
<description></description>
<valueType>uint8</valueType>
<writeable/>
<odmVisable/>
</attribute>

<attribute>
Expand All @@ -60,7 +58,6 @@
<description>Defines the start address for the Mcbist address range</description>
<valueType>uint64</valueType>
<writeable/>
<odmVisable/>
</attribute>

<attribute>
Expand All @@ -69,7 +66,6 @@
<description>Defines the end address for the Mcbist address range</description>
<valueType>uint64</valueType>
<writeable/>
<odmVisable/>
</attribute>

<attribute>
Expand All @@ -78,7 +74,6 @@
<description>Enables error capture; basically a flag.</description>
<valueType>uint8</valueType>
<writeable/>
<odmVisable/>
</attribute>

<attribute>
Expand All @@ -87,7 +82,6 @@
<description>Define mcbist Max timeout</description>
<valueType>uint64</valueType>
<writeable/>
<odmVisable/>
</attribute>

<attribute>
Expand All @@ -96,7 +90,6 @@
<description>Enable which port prints are required.</description>
<valueType>uint8</valueType>
<writeable/>
<odmVisable/>
</attribute>

<attribute>
Expand All @@ -105,7 +98,6 @@
<description>Flag to stop Mcbist on Error.</description>
<valueType>uint8</valueType>
<writeable/>
<odmVisable/>
</attribute>

<attribute>
Expand All @@ -114,7 +106,6 @@
<description>Define data seed for the random data pattern or test</description>
<valueType>uint32</valueType>
<writeable/>
<odmVisable/>
</attribute>

<attribute>
Expand All @@ -123,7 +114,6 @@
<description>The address interleave map with user cases or deafult cases of BANK_RANK,RANK_BANK,BANK_ONLY,RANK_ONLYRANKS_DIMM0,RANKS_DIMM1,USER_PATTERN.</description>
<valueType>uint8</valueType>
<writeable/>
<odmVisable/>
</attribute>

<attribute>
Expand All @@ -132,7 +122,6 @@
<description>User defined constraint for limiting number of rows for addressing.</description>
<valueType>uint8</valueType>
<writeable/>
<odmVisable/>
</attribute>

<attribute>
Expand All @@ -141,7 +130,6 @@
<description>User defined constraint for limiting number of columns for addressing.</description>
<valueType>uint8</valueType>
<writeable/>
<odmVisable/>
</attribute>

<attribute>
Expand All @@ -150,7 +138,6 @@
<description>User defined constraint for limiting number of ranks for addressing.</description>
<valueType>uint8</valueType>
<writeable/>
<odmVisable/>
</attribute>

<attribute>
Expand All @@ -159,7 +146,6 @@
<description>User defined constraint for limiting number of banks for addressing.</description>
<valueType>uint8</valueType>
<writeable/>
<odmVisable/>
</attribute>

<attribute>
Expand All @@ -168,7 +154,6 @@
<description>If slave ranks exists;Restrict usage or enable addressing on them as well.</description>
<valueType>uint8</valueType>
<writeable/>
<odmVisable/>
</attribute>

<attribute>
Expand All @@ -177,7 +162,6 @@
<description>To Define custom addressing map ; Input by user.</description>
<valueType>uint64</valueType>
<writeable/>
<odmVisable/>
</attribute>

<attribute>
Expand All @@ -186,7 +170,6 @@
<description>Flag for Addressing to go sequential manner or random.</description>
<valueType>uint8</valueType>
<writeable/>
<odmVisable/>
</attribute>

</attributes>

0 comments on commit 9d54c3e

Please sign in to comment.