Skip to content

Commit

Permalink
Update some defaults for AVSBUS attributes
Browse files Browse the repository at this point in the history
Added explicit defaults for AVSBUS attributes
Deleted ATTR_VCS_ID_RAIL

Change-Id: I8fdcd049d209af34dfa6ef354a4452641b9ee345
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/59461
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: RANGANATHPRASAD BRAHMASAMUDRA <prasadbgr@in.ibm.com>
Reviewed-by: Gregory S. Still <stillgs@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/59473
Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
Tested-by: Christian R. Geddes <crgeddes@us.ibm.com>
  • Loading branch information
dcrowell77 authored and crgeddes committed Jun 21, 2018
1 parent f5c9608 commit a4dca21
Showing 1 changed file with 8 additions and 20 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -212,11 +212,11 @@
Pstate Parameter Block (PSPB) for PGPE

*MOST* systems use Bus 0 for VDD. If this is not the case, the value
must be appropriately set by the platform (eg MRWB or equivalent
must be appropriately set by the platform (eg MRWB or equivalent)
</description>
<valueType>uint8</valueType>
<platInit/>
<initToZero/>
<default>0</default>
</attribute>
<!-- ********************************************************************* -->
<attribute>
Expand All @@ -236,6 +236,7 @@
</description>
<valueType>uint8</valueType>
<platInit/>
<default>1</default>
</attribute>
<!-- ********************************************************************* -->
<attribute>
Expand All @@ -254,6 +255,7 @@
</description>
<valueType>uint8</valueType>
<platInit/>
<default>0xFF</default>
</attribute>
<!-- ********************************************************************* -->
<attribute>
Expand All @@ -275,7 +277,7 @@
</description>
<valueType>uint8</valueType>
<platInit/>
<initToZero/>
<default>0</default>
</attribute>
<!-- ********************************************************************* -->
<attribute>
Expand All @@ -297,7 +299,7 @@
</description>
<valueType>uint8</valueType>
<platInit/>
<initToZero/>
<default>0</default>
</attribute>
<!-- ********************************************************************* -->
<attribute>
Expand All @@ -316,7 +318,7 @@
</description>
<valueType>uint8</valueType>
<platInit/>
<initToZero/> <!-- This here strictly to allocate the attribute in Cronus -->
<default>0xFF</default>
</attribute>
<!-- ********************************************************************* -->
<attribute>
Expand All @@ -331,21 +333,7 @@
</description>
<valueType>uint8</valueType>
<platInit/>
</attribute>
<!-- ********************************************************************* -->
<attribute>
<id>ATTR_VCS_I2C_RAIL</id>
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
<description>
Defines the I2C rail selector number (0 - 15) for the VCS VRM on the
bus defined by ATTR_VCS_I2C_BUSNUM.

Producer: Machine Readable Workbook
Consumers: p9_set_evid;
p9_set_voltage (tool)
</description>
<valueType>uint8</valueType>
<platInit/>
<default>0xFF</default>
</attribute>
<!-- ********************************************************************* -->
<attribute>
Expand Down

0 comments on commit a4dca21

Please sign in to comment.