Skip to content

Commit

Permalink
Only call PRD attention handling in resetPMComplex function at runtime.
Browse files Browse the repository at this point in the history
HB can't call PRD handling after istep 16.4.  If this util function
happens to be called after that istep but before runtime, we may see
some unwanted PRD errors.

Change-Id: Ie4f9a55fe1e74f7835d9f30531b757a79d36b14e
CQ:SW448154
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/67621
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com>
  • Loading branch information
ibmthi authored and Nicholas E. Bofferding committed Oct 18, 2018
1 parent 8652b51 commit a515f16
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion src/usr/isteps/pm/pm_common.C
Original file line number Diff line number Diff line change
Expand Up @@ -958,11 +958,13 @@ namespace HBPM
"resetPMComplex: p9_pm_init(PM_RESET) succeeded "
"HUID=0x%08X", get_huid(i_target) );

#ifdef __HOSTBOOT_RUNTIME

// Explicitly call ATTN before exiting to ensure PRD handles
// LFIR before TMGT triggers PM Complex Init, but only if
// we aren't already in the middle of handling a core checkstop
if( HB_INITIATED_PM_RESET_IN_PROGRESS != l_chipResetState )
{
{
// set ATTR_HB_INITIATED_PM_RESET to IN_PROGRESS to avoid recursion
i_target->setAttr<ATTR_HB_INITIATED_PM_RESET>
(HB_INITIATED_PM_RESET_IN_PROGRESS);
Expand All @@ -982,6 +984,9 @@ namespace HBPM
break;
}
}

#endif

} while(0);

if ((TARGETING::is_phyp_load()) && (nullptr != l_homerVAddr))
Expand Down

0 comments on commit a515f16

Please sign in to comment.