Skip to content

Commit

Permalink
Another fix to symsmode parms for debug mode
Browse files Browse the repository at this point in the history
Fixed the mismatched default parm between hb-dump-debug and the
framework.

Change-Id: Id3af424ed65ed371d9c9dfc09be00212bfe87acb
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/65367
Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
  • Loading branch information
dcrowell77 authored and wghoffa committed Aug 30, 2018
1 parent c8448c3 commit a5e1315
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/build/debug/ecmd-debug-framework.pl
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
$tool = basename $0;
}

# "" : Default - Try to use memory, fall-back to symbol files
# "default" : Default - Try to use memory, fall-back to symbol files
# "usefile" : Only use the symbol files
# "usemem" : Only use the data from memory
my $useSymsMode = "default";
Expand Down
4 changes: 2 additions & 2 deletions src/build/debug/hb-dump-debug
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,10 @@ if (defined ($hbDir))
}
}

# "both" : Try to use memory, fall-back to symbol files
# "default" : Try to use memory, fall-back to symbol files
# "usefile" : Only use the symbol files
# "usemem" : Only use the data from memory
my $useSymsMode = "both";
my $useSymsMode = "default";

GetOptions("tool:s" => \$tool,
"tool-options:s" => \$toolOptions,
Expand Down

0 comments on commit a5e1315

Please sign in to comment.