Skip to content

Commit

Permalink
Allow update of zeroed NVDIMM level
Browse files Browse the repository at this point in the history
Version 00 means the slot is blank,
so a code update should be allowed.

Change-Id: I0dc685ff72c699e1c3062a5b92e8679516305ca4
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/75889
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: TSUNG K. YEUNG <tyeung@us.ibm.com>
Reviewed-by: Corey V. Swenson <cswenson@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
mderkse1 authored and dcrowell77 committed Apr 12, 2019
1 parent 882f15e commit b6e5039
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/usr/isteps/nvdimm/nvdimm_update.C
Expand Up @@ -5,7 +5,7 @@
/* */
/* OpenPOWER HostBoot Project */
/* */
/* Contributors Listed Below - COPYRIGHT 2018 */
/* Contributors Listed Below - COPYRIGHT 2018,2019 */
/* [+] International Business Machines Corp. */
/* */
/* */
Expand Down Expand Up @@ -2031,8 +2031,8 @@ errlHndl_t NvdimmsUpdate::isUpdateNeeded(bool & o_update_needed,
// Put a check here for non-updateable SMART NVDIMMs.
// Anything before 0x0030 should bypass the update, as update
// would fail due to a bug in the backlevel firmware on the
// nvdimm card
if (le16toh(curVersion) < 0x0030)
// nvdimm card (exception: 0x0000 = slot blank so allow update)
if ((curVersion != 0x0000) && (le16toh(curVersion) < 0x0030))
{
TRACFCOMP(g_trac_nvdimm_upd,
"isUpdateNeeded(): non-updatable SMART NVDIMM 0x%.8X "
Expand Down

0 comments on commit b6e5039

Please sign in to comment.