Skip to content

Commit

Permalink
ATTR_PBAX_GROUPID: add global tag
Browse files Browse the repository at this point in the history
PBAX_GROUPID is a proc level attr that needs
to be incrememnted per node. The only way to
set this correctly in MRW is to add a global
tag. However, making it global may break other
systems as the global value in their respective
MRW won't be set. It will be set on proc_socket
level. Therefore, added a check to only copy
global values if they are not empty (aka someone
must explicitly set the global value for us to
use those values).

Change-Id: I3055d8296c010f996d98d7578a9adee5b763d316
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/55257
Reviewed-by: Santosh S. Puranik <santosh.puranik@in.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
  • Loading branch information
Prachi Gupta authored and wghoffa committed Mar 8, 2018
1 parent 4cf79f8 commit b98f4c6
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/usr/targeting/common/Targets.pm
Original file line number Diff line number Diff line change
Expand Up @@ -487,7 +487,10 @@ sub buildHierarchy
{
my $val=$settingptr->{$key}->{property}->
{$prop}->{value};
$self->setAttribute($key, $prop, $val);
if ($val ne "")
{
$self->setAttribute($key, $prop, $val);
}
}

## Save busses
Expand Down
5 changes: 5 additions & 0 deletions src/usr/targeting/common/xmltohb/hb_customized_attrs.xml
Original file line number Diff line number Diff line change
Expand Up @@ -668,6 +668,11 @@
<writeable/>
</attribute>

<attribute>
<id>ATTR_PBAX_GROUPID</id>
<global/>
</attribute>

<attribute>
<id>CEN_MSS_CACHE_ENABLE</id>
<no_export/>
Expand Down

0 comments on commit b98f4c6

Please sign in to comment.