Skip to content

Commit

Permalink
Secure Boot: Detach secure PNOR provider task
Browse files Browse the repository at this point in the history
Once secure PNOR provider task starts, immediately detach it so that, should
it die, Hostboot will terminate; otherwise, Hostboot can hang until terminated
by a service processor boot timeout.

Change-Id: I586db0bb56e7e1eedb1183cda34e4bda4bc03bbd
CQ: SW419735
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/55048
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: ILYA SMIRNOV <ismirno@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
Nick Bofferding authored and dcrowell77 committed Mar 7, 2018
1 parent 7415640 commit bd1cd3c
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/usr/pnor/spnorrp.C
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
#include <secureboot/containerheader.H>
#include <secureboot/trustedbootif.H>
#include <secureboot/header.H>
#include <sys/task.h>

extern trace_desc_t* g_trac_pnor;

Expand Down Expand Up @@ -72,6 +73,9 @@ using namespace PNOR;
*/
void* secure_wait_for_message( void* unused )
{
// Mark task as an independent daemon so if it crashes, Hostboot will
// terminate
(void)task_detach();
TRACUCOMP(g_trac_pnor, "wait_for_message> " );
Singleton<SPnorRP>::instance().waitForMessage();
return NULL;
Expand Down

0 comments on commit bd1cd3c

Please sign in to comment.