Skip to content

Commit

Permalink
Delete non-terminating TPM error in fabric integration step
Browse files Browse the repository at this point in the history
Deletes a non-terminating TPM error in the fabric integration step to
avoid setting up a race condition on FSP that results in FSP not waking
Hostboot up from winkle properly.  That issue will be pervasively addressed by
SW444320.

Change-Id: I1f43f704a53ec77593d082021cc545e2365d499a
CQ: SW443597
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/65594
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com>
  • Loading branch information
Nick Bofferding committed Sep 4, 2018
1 parent 9da5e1b commit bdb1634
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion src/usr/secureboot/node_comm/node_comm_exchange.C
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,16 @@ errlHndl_t nodeCommAbusGetRandom(uint64_t & o_nonce)
err->collectTrace(SECURE_COMP_NAME);
err->collectTrace(NODECOMM_TRACE_NAME);
err->collectTrace(TRBOOT_COMP_NAME);
errlCommit(err, SECURE_COMP_ID);

// @TODO CQ: SW444320
//
// Restore errlCommit of this error as part of the referenced
// defect fix. Until that fix is in place, committing an error
// in this path with the intent of continuing would set up a condition
// where FSP fails to wake Hostboot out of winkle state.
delete err;
err=nullptr;
//errlCommit(err, SECURE_COMP_ID);
}

TRACFCOMP(g_trac_nc,EXIT_MRK"nodeCommAbusGetRandom: "
Expand Down

0 comments on commit bdb1634

Please sign in to comment.