Skip to content

Commit

Permalink
PRD: use isValid() check before MemSymbol::getDram()
Browse files Browse the repository at this point in the history
Change-Id: I79df99da27936b9b2967812ac1489432c9108fb0
CQ: SW431098
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/59496
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Zane C. Shelley <zshelle@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/59521
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
  • Loading branch information
cnpalmer authored and zane131 committed May 30, 2018
1 parent 5043493 commit c0996da
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/usr/diag/prdf/common/plat/mem/prdfMemMark.C
Original file line number Diff line number Diff line change
Expand Up @@ -983,8 +983,9 @@ uint32_t __applyRasPolicies<TYPE_MBA>( ExtensibleChip * i_chip,
// If the chip mark is on a spare then the spare is bad and hardware
// can not steer it to another DRAM even if one is available (e.g.
// the ECC spare). In this this case, make error log predictive.
if ( ( dram == (0 == ps ? sp0.getDram() : sp1.getDram()) ) ||
( dram == ecc.getDram() ) )
if ( ( (0 == ps) && sp0.isValid() && (dram == sp0.getDram()) ) ||
( (1 == ps) && sp1.isValid() && (dram == sp1.getDram()) ) ||
( isX4 && ecc.isValid() && (dram == ecc.getDram()) ) )
{
allRepairsUsed = true;
io_sc.service_data->setSignature( i_chip->getHuid(),
Expand Down

0 comments on commit c0996da

Please sign in to comment.