Skip to content

Commit

Permalink
Update phy_pharams structure, tests, and exp attrs
Browse files Browse the repository at this point in the history
Change-Id: Ie84463e9497bf53d8cd13b14526be93d9de95506
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/72070
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com>
Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: ANDRE A. MARIN <aamarin@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/72086
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
  • Loading branch information
aamarin authored and crgeddes committed Mar 13, 2019
1 parent 5618f2f commit c368037
Show file tree
Hide file tree
Showing 3 changed files with 919 additions and 553 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -73,16 +73,14 @@ fapi2::ReturnCode setup_phy_params(const fapi2::Target<fapi2::TARGET_TYPE_OCMB_C
for (const auto l_port : mss::find_targets<fapi2::TARGET_TYPE_MEM_PORT>(i_target))
{
fapi2::ReturnCode l_rc;

// Create an object
auto l_set_phy_params = phy_params(l_port, l_rc);
FAPI_TRY(l_rc, "Unable to set parameters for target %s", mss::c_str(i_target));
const phy_params l_set_phy_params(l_port, l_rc);
FAPI_TRY(l_rc, "Unable to instantiate phy_params for target %s", mss::c_str(i_target));

// Set the params by fetching them from the attributes
FAPI_TRY(l_set_phy_params.setup_DimmType(l_port, o_phy_params));
FAPI_TRY(l_set_phy_params.setup_CsPresent(l_port, o_phy_params));
FAPI_TRY(l_set_phy_params.setup_DramDataWidth(l_port, o_phy_params));
FAPI_TRY(l_set_phy_params.setup_Height3DS(l_port, o_phy_params));
FAPI_TRY(l_set_phy_params.setup_DimmType(o_phy_params));
FAPI_TRY(l_set_phy_params.setup_CsPresent(o_phy_params));
FAPI_TRY(l_set_phy_params.setup_DramDataWidth(o_phy_params));
FAPI_TRY(l_set_phy_params.setup_Height3DS(o_phy_params));
FAPI_TRY(l_set_phy_params.set_ActiveDBYTE(o_phy_params));
FAPI_TRY(l_set_phy_params.set_ActiveNibble(o_phy_params));
FAPI_TRY(l_set_phy_params.set_AddrMirror(o_phy_params));
Expand Down

0 comments on commit c368037

Please sign in to comment.