Skip to content

Commit

Permalink
errl: Free memory allocated for parsers
Browse files Browse the repository at this point in the history
Errl's factory creates new instance of User Defined Data parser
on every call, but doesn't free it after usage.

Resolves #184
Signed-off-by: Artem Senichev <a.senichev@yadro.com>
Change-Id: I8e8bd54e7aaa4ddb813cec3485404b6ba7a29ffa
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84518
Reviewed-by: Corey V Swenson <cswenson@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Matt Derksen <mderkse1@us.ibm.com>
Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
  • Loading branch information
Artem Senichev authored and dcrowell77 committed Oct 3, 2019
1 parent ad8653d commit c79620a
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/usr/errl/plugins/errludparser.H
Expand Up @@ -5,8 +5,9 @@
/* */
/* OpenPOWER HostBoot Project */
/* */
/* Contributors Listed Below - COPYRIGHT 2012,2018 */
/* Contributors Listed Below - COPYRIGHT 2012,2019 */
/* [+] International Business Machines Corp. */
/* [+] YADRO */
/* */
/* */
/* Licensed under the Apache License, Version 2.0 (the "License"); */
Expand Down Expand Up @@ -84,6 +85,7 @@ static bool myDataParse(\
{\
l_rc = true;\
l_pParser->parse(i_ver, i_parser, i_buffer, i_buflen);\
delete l_pParser;\
}\
return l_rc;\
}\
Expand Down

0 comments on commit c79620a

Please sign in to comment.