Skip to content

Commit

Permalink
Double the NVDIMM_READY timeout to prevent erroneous error
Browse files Browse the repository at this point in the history
NVDIMM controller POR or firmware induced reset time may vary
from run-to-run. Doubling the timeout here in case of edge
condition.

Change-Id: I717dfbef9b2903e8bb1e7aed92c28df1fab90033
CQ:SW476597
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/84107
Reviewed-by: Matt Derksen <mderkse1@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Corey V Swenson <cswenson@us.ibm.com>
Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
  • Loading branch information
Tsung Yeung authored and dcrowell77 committed Sep 24, 2019
1 parent b7c4af2 commit c7a3665
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/usr/isteps/nvdimm/nvdimm.C
Expand Up @@ -494,8 +494,8 @@ errlHndl_t nvdimmReady(Target *i_nvdimm)
break;
}

// Convert to ms for polling
uint32_t l_nvm_init_time_ms = l_nvm_init_time * MS_PER_SEC;
// Convert to ms for polling and double the value to avoid edge condition
uint32_t l_nvm_init_time_ms = l_nvm_init_time * MS_PER_SEC * 2;
uint32_t l_poll = 0;

do
Expand Down

0 comments on commit c7a3665

Please sign in to comment.