Skip to content

Commit

Permalink
Get ring override failing
Browse files Browse the repository at this point in the history
Get ring override is an optional code path but it halts the boot
process when it returns a failure. Optional code path should still
continue the boot process as normal even on a failure. Error
logs should still continue as normal.

Change-Id: I869e7bcaee5993b601af1e63273f597e1310fbfd
CQ: SW455865
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/75173
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com>
  • Loading branch information
chenduibm authored and Nicholas E. Bofferding committed Apr 3, 2019
1 parent e904aae commit c824d6f
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions src/usr/isteps/pm/pm_common.C
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
/* */
/* OpenPOWER HostBoot Project */
/* */
/* Contributors Listed Below - COPYRIGHT 2016,2018 */
/* Contributors Listed Below - COPYRIGHT 2016,2019 */
/* [+] International Business Machines Corp. */
/* */
/* */
Expand Down Expand Up @@ -327,11 +327,12 @@ namespace HBPM
// include it in if so
void* l_ringOverrides = nullptr;
l_errl = HBPM::getRingOvd(l_ringOverrides);
if(l_errl)
if (l_errl)
{
TRACFCOMP( ISTEPS_TRACE::g_trac_isteps_trace,
ERR_MRK"loadHcode(): Error in call to getRingOvd!");
break;
l_errl->setSev(ERRORLOG::ERRL_SEV_INFORMATIONAL);
errlCommit(l_errl, ISTEP_COMP_ID);
}

FAPI_INVOKE_HWP( l_errl,
Expand Down

0 comments on commit c824d6f

Please sign in to comment.