Skip to content

Commit

Permalink
Serialize the Check For Prologs in CI
Browse files Browse the repository at this point in the history
Prolog checks are performed in parallel with build in hostboot
CI process, and the return code from the prolog checking
script is checked after the build job completes, which
introduces significant delays before the developer is informed
of incorrect prologs. This change serializes the check for
prolog correctness and forces the check to run before the build
process, so that the developer is informed about bad prologs
as soon as possible.

Change-Id: Ib84802f14022712268db1b0b539396e59d25792f
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/68678
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
Ilya Smirnov authored and dcrowell77 committed Nov 19, 2018
1 parent cd754bf commit c851139
Showing 1 changed file with 10 additions and 12 deletions.
22 changes: 10 additions & 12 deletions src/build/citest/build-script
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,16 @@ echo "#--------------------------------"
export SECURITY_HW_POLICY="1"

# Check copyright.
check-copyright > copyright.log 2>&1 &
COPYRIGHT_PID=$!
check-copyright > copyright.log 2>&1
if [ $? -eq 0 ]; then
echo "----Copyright check succeeded."
cat copyright.log
else
echo "----Copyright check failed."
cat copyright.log
exit -1
fi


# Create simics sandbox.
create-sandbox > create-sandbox.log 2>&1 &
Expand All @@ -57,16 +65,6 @@ make -j32 || exit -1
echo "#--------------------------------"
printf "\n\nrc=$?: $(date): FINISHED running (\"make -j32\" was started at $my_date)\n\n"
echo "#--------------------------------"
# Check copyright completion.
wait $COPYRIGHT_PID
if [ $? -eq 0 ]; then
echo "----Copyright check succeeded."
cat copyright.log
else
echo "----Copyright check failed."
cat copyright.log
exit -1
fi

# Check sandbox create completion.
wait $CREATESANDBOX_PID
Expand Down

0 comments on commit c851139

Please sign in to comment.