Update TCE Testcases

This commit updates and enables the TCE testcases used in HB standalone simics configurations. It also does some minor cleanup to address all outstanding TODOs for this story. Change-Id: I6b1ca049633a8c70b53bb35c776403dc86fec86b RTC:168745 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/54085 Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com> Reviewed-by: ILYA SMIRNOV <ismirno@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
open-power · Feb 17, 2018 · c93bef3 · c93bef3
1 parent 8acb64a
commit c93bef3
Show file tree

Hide file tree

Showing 4 changed files with 177 additions and 270 deletions.
diff --git a/src/usr/dump/dumpCollect.C b/src/usr/dump/dumpCollect.C
@@ -842,19 +842,19 @@ errlHndl_t copySrcToDest(dumpEntry *srcTableEntry,
                     if (TCE::utilUseTcesForDmas())
                     {
                         // Align Physical addr down for TCE requirement
-                        uint64_t mdrt_phyp_aligned =
+                        uint64_t mdrt_phys_aligned =
                                    ALIGN_PAGE_DOWN(l_mdrt_phys);
 
-                        uint64_t offset = l_mdrt_phys - mdrt_phyp_aligned;
+                        uint64_t offset = l_mdrt_phys - mdrt_phys_aligned;
 
                         TRACFCOMP( g_trac_dump,"Setup TCEs for FSP to use for "
                                    "l_mdrt_phys=0x%.16llX (virt=0x%.16llX, "
                                    "aligned_phys=0x%.16llX, offset=0x%X)",
                                    l_mdrt_phys, resultsTableAddr,
-                                   mdrt_phyp_aligned, offset);
+                                   mdrt_phys_aligned, offset);
 
                         uint32_t token = 0;
-                        l_err = TCE::utilAllocateTces(mdrt_phyp_aligned,
+                        l_err = TCE::utilAllocateTces(mdrt_phys_aligned,
                                                       resultsTableSize+offset,
                                                       token,
                                                       false); //Read-Only

diff --git a/src/usr/isteps/istep16/call_host_ipl_complete.C b/src/usr/isteps/istep16/call_host_ipl_complete.C
@@ -111,7 +111,7 @@ void* call_host_ipl_complete (void *io_pArgs)
             l_err = nullptr;
         }
 #endif
-        //@TODO RTC:172767
+        //@TODO RTC:187335
         //TCE setup is broken on multinode.  This is a quick hack to only do it
         //on drawer 0 (and if you don't have a drawer 0 this is busted)
         TARGETING::Target* mproc = nullptr;