Skip to content

Commit

Permalink
PRD: Update OCMB_LFIR[38] to defaultMaskedError
Browse files Browse the repository at this point in the history
OCMB_LFIR[38] will now be masked because both checkers
for the error are broken.

Change-Id: I4cd8d3ba1c195bb9a2f537b3f8e2a1da288c6d24
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/94977
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Brian J Stegmiller <bjs@us.ibm.com>
Reviewed-by: Benjamen G Tyner <ben.tyner@ibm.com>
Reviewed-by: Zane C Shelley <zshelle@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/95367
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
  • Loading branch information
cnpalmer authored and zane131 committed Apr 21, 2020
1 parent 7bf1bbf commit cc929c6
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 59 deletions.
4 changes: 2 additions & 2 deletions src/usr/diag/prdf/common/plat/explorer/explorer_ocmb.rule
Expand Up @@ -5,7 +5,7 @@
#
# OpenPOWER HostBoot Project
#
# Contributors Listed Below - COPYRIGHT 2018,2019
# Contributors Listed Below - COPYRIGHT 2018,2020
# [+] International Business Machines Corp.
#
#
Expand Down Expand Up @@ -589,7 +589,7 @@ group gOCMB_LFIR
/** OCMB_LFIR[38]
* DDR4 PHY interrupt
*/
(rOCMB_LFIR, bit(38)) ? ddr4_phy_interrupt;
(rOCMB_LFIR, bit(38)) ? defaultMaskedError;

/** OCMB_LFIR[39:46]
* foxhound fatal
Expand Down
Expand Up @@ -261,14 +261,6 @@ actionclass TBDDefaultCallout
# OCMB Actions #
################################################################################

/** DDR4 PHY Interrupt */
actionclass ddr4_phy_interrupt
{
calloutSelfHigh;
threshold5pday;
funccall("Ddr4PhyInterrupt");
};

/** Foxhound Fatal */
actionclass foxhound_fatal
{
Expand Down
Expand Up @@ -109,55 +109,6 @@ PRDF_PLUGIN_DEFINE( explorer_ocmb, PostAnalysis );
//
//##############################################################################

/**
* @brief OCMB_LFIR[38] - DDR4 PHY interrupt
* @param i_chip An OCMB chip.
* @param io_sc The step code data struct.
* @return SUCCESS
*/
int32_t Ddr4PhyInterrupt( ExtensibleChip * i_chip,
STEP_CODE_DATA_STRUCT & io_sc )
{
#define PRDF_FUNC "[explorer_ocmb::Ddr4PhyInterrupt] "

SCAN_COMM_REGISTER_CLASS * rdffir = i_chip->getRegister( "RDFFIR" );

// If Mainline UE (RDFFIR[14]) or Maint UE (RDFFIR[34]) are on at the same
// time as this:
if ( rdffir->IsBitSet(14) || rdffir->IsBitSet(34) )
{
// callout Explorer on 1st
io_sc.service_data->SetThresholdMaskId(0);

// mask maint and mainline UE which are assumed to be side-effects
SCAN_COMM_REGISTER_CLASS * rdffir_mask_or =
i_chip->getRegister( "RDFFIR_MASK_OR" );

rdffir_mask_or->SetBit(14);
rdffir_mask_or->SetBit(34);

if ( SUCCESS != rdffir_mask_or->Write() )
{
PRDF_ERR( PRDF_FUNC "Write() failed on RDFFIR_MASK_OR: 0x%08x",
i_chip->getHuid() );
}
}
else
{
//TODO RTC 200583
// callout Explorer on threshold (5/day)
// NOTE: in this case we will have to clear both hw driven checkers
// manually before clearing the FIR
}

return SUCCESS;

#undef PRDF_FUNC
}
PRDF_PLUGIN_DEFINE( explorer_ocmb, Ddr4PhyInterrupt );

//------------------------------------------------------------------------------

/**
* @brief OCMB_LFIR[39:46] - Foxhound Fatal
* @param i_chip An OCMB chip.
Expand Down

0 comments on commit cc929c6

Please sign in to comment.