Skip to content

Commit ce2eb29

Browse files
crgeddesdcrowell77
authored andcommitted
Remove workaround clearing OCB Linear Window security bit during MPIPL
Change-Id: I6321605f0c34188b1c46f873e5100ca370555ede RTC: 173716 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/46294 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Corey V. Swenson <cswenson@us.ibm.com> Reviewed-by: Elizabeth K. Liner <eliner@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
1 parent dd6b90e commit ce2eb29

File tree

1 file changed

+0
-51
lines changed

1 file changed

+0
-51
lines changed

src/usr/isteps/istep06/host_discover_targets.C

Lines changed: 0 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -529,59 +529,8 @@ void* host_discover_targets( void *io_pArgs )
529529
"host_discover_targets: MPIPL mode, targeting"
530530
"information has already been loaded from memory"
531531
"when the targeting service started");
532-
533-
//TODO RTC: 173716
534-
// Remove workaround clearing OCB Linear Window security bit during MPIPL
535-
TARGETING::TargetHandleList l_procChips;
536-
getAllChips( l_procChips, TARGETING::TYPE_PROC );
537-
538-
uint64_t l_ocb_lw_control_value = 0;
539-
size_t l_size = sizeof(l_ocb_lw_control_value);
540-
541-
for (const auto & l_procChip: l_procChips)
542-
{
543-
//We are doing a Read-Modify-Write on the Linear Window Control reg
544-
l_err = deviceRead(l_procChip,
545-
&l_ocb_lw_control_value,
546-
l_size,
547-
DEVICE_SCOM_ADDRESS(PU_OCB_OCI_OCBLWCR0_SCOM)); //0x6C208
548-
549-
if(l_err)
550-
{
551-
TRACFCOMP(ISTEPS_TRACE::g_trac_isteps_trace,
552-
"host_discover_targets: Failed to read scom address 0x%lx",
553-
PU_OCB_OCI_OCBLWCR0_SCOM);
554-
ERRORLOG::ErrlUserDetailsTarget(l_procChip).addToLog(l_err);
555-
l_err->collectTrace(TARG_COMP_NAME);
556-
break;
557-
}
558-
559-
//Clear bit 0
560-
l_ocb_lw_control_value &= 0x7FFFFFFFFFFFFFFF;
561-
562-
l_err = deviceWrite(l_procChip,
563-
&l_ocb_lw_control_value,
564-
l_size,
565-
DEVICE_SCOM_ADDRESS(PU_OCB_OCI_OCBLWCR0_SCOM)); //0x6C208
566-
if(l_err)
567-
{
568-
TRACFCOMP(ISTEPS_TRACE::g_trac_isteps_trace,
569-
"host_discover_targets: Failed to write 0x%lx scom address 0x%lx",
570-
l_ocb_lw_control_value, PU_OCB_OCI_OCBLWCR0_SCOM);
571-
ERRORLOG::ErrlUserDetailsTarget(l_procChip).addToLog(l_err);
572-
l_err->collectTrace(TARG_COMP_NAME);
573-
break;
574-
}
575-
}
576-
577532
do
578533
{
579-
//If there is an error skip these steps .. something is wrong
580-
if (l_err)
581-
{
582-
break;
583-
}
584-
585534
//Need to power down the slave quads
586535
l_err = powerDownSlaveQuads();
587536
if (l_err)

0 commit comments

Comments
 (0)