Skip to content

Commit

Permalink
Remove workaround clearing OCB Linear Window security bit during MPIPL
Browse files Browse the repository at this point in the history
Change-Id: I6321605f0c34188b1c46f873e5100ca370555ede
RTC: 173716
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/46294
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Corey V. Swenson <cswenson@us.ibm.com>
Reviewed-by: Elizabeth K. Liner <eliner@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
crgeddes authored and dcrowell77 committed Sep 21, 2017
1 parent dd6b90e commit ce2eb29
Showing 1 changed file with 0 additions and 51 deletions.
51 changes: 0 additions & 51 deletions src/usr/isteps/istep06/host_discover_targets.C
Expand Up @@ -529,59 +529,8 @@ void* host_discover_targets( void *io_pArgs )
"host_discover_targets: MPIPL mode, targeting"
"information has already been loaded from memory"
"when the targeting service started");

//TODO RTC: 173716
// Remove workaround clearing OCB Linear Window security bit during MPIPL
TARGETING::TargetHandleList l_procChips;
getAllChips( l_procChips, TARGETING::TYPE_PROC );

uint64_t l_ocb_lw_control_value = 0;
size_t l_size = sizeof(l_ocb_lw_control_value);

for (const auto & l_procChip: l_procChips)
{
//We are doing a Read-Modify-Write on the Linear Window Control reg
l_err = deviceRead(l_procChip,
&l_ocb_lw_control_value,
l_size,
DEVICE_SCOM_ADDRESS(PU_OCB_OCI_OCBLWCR0_SCOM)); //0x6C208

if(l_err)
{
TRACFCOMP(ISTEPS_TRACE::g_trac_isteps_trace,
"host_discover_targets: Failed to read scom address 0x%lx",
PU_OCB_OCI_OCBLWCR0_SCOM);
ERRORLOG::ErrlUserDetailsTarget(l_procChip).addToLog(l_err);
l_err->collectTrace(TARG_COMP_NAME);
break;
}

//Clear bit 0
l_ocb_lw_control_value &= 0x7FFFFFFFFFFFFFFF;

l_err = deviceWrite(l_procChip,
&l_ocb_lw_control_value,
l_size,
DEVICE_SCOM_ADDRESS(PU_OCB_OCI_OCBLWCR0_SCOM)); //0x6C208
if(l_err)
{
TRACFCOMP(ISTEPS_TRACE::g_trac_isteps_trace,
"host_discover_targets: Failed to write 0x%lx scom address 0x%lx",
l_ocb_lw_control_value, PU_OCB_OCI_OCBLWCR0_SCOM);
ERRORLOG::ErrlUserDetailsTarget(l_procChip).addToLog(l_err);
l_err->collectTrace(TARG_COMP_NAME);
break;
}
}

do
{
//If there is an error skip these steps .. something is wrong
if (l_err)
{
break;
}

//Need to power down the slave quads
l_err = powerDownSlaveQuads();
if (l_err)
Expand Down

0 comments on commit ce2eb29

Please sign in to comment.