Skip to content

Commit

Permalink
Fix ipmifruinv calls for dimms in swift systems
Browse files Browse the repository at this point in the history
We had a bug in the VPD map for the the DDR4_DDIMMs where we were
missing fields that were expected in the data collection for the
fruinventory. This commit adds the field we were missing and also
adds the PART_NUMBER field which the BMC is currently just leaving
blank.

Change-Id: I65dbfb0b79bef9d3a9a3bf2d6aa135c5df5ece56
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86420
Reviewed-by: William G Hoffa <wghoffa@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Matt Derksen <mderkse1@us.ibm.com>
Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
  • Loading branch information
crgeddes authored and dcrowell77 committed Nov 6, 2019
1 parent 22b39d8 commit d1260d0
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/usr/vpd/spdDDR4_DDIMM.H
Expand Up @@ -104,8 +104,10 @@ const KeywordData ddr4DDIMMData[] =
{ TRPMIN_FINE_OFFSET, 0x79, 0x01, 0x00, 0x00, false, false, ALL },
{ TRCMIN_FINE_OFFSET, 0x78, 0x01, 0x00, 0x00, false, false, ALL },
// Note - All data below 128 is common across all DDR4 DIMMs, except DDIMM
{ MODULE_MANUFACTURER_ID, 0x200, 0x02, 0x00, 0x00, true, false, ALL },
{ MODULE_SERIAL_NUMBER, 0x205, 0x04, 0x00, 0x00, false, false, ALL },
{ MODULE_PART_NUMBER, 0x209, 0x1E, 0x00, 0x00, false, false, ALL },
{ MODULE_REVISION_CODE, 0x277, 0x01, 0x00, 0x00, false, false, ALL },
// Normal fields supported on DDR4 only
{ BANK_GROUP_BITS, 0x04, 0x01, 0xC0, 0x06, false, false, ALL },
{ BANK_ADDRESS_BITS_DDR4, 0x04, 0x01, 0x30, 0x04, false, false, ALL },
Expand Down

0 comments on commit d1260d0

Please sign in to comment.