Skip to content

Commit

Permalink
PRD: Uncomment Axone HWP code
Browse files Browse the repository at this point in the history
Change-Id: I1d60cd40e93974a9a71bee35d27b2a2b7f3be510
RTC: 207273
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86516
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Benjamen G Tyner <ben.tyner@ibm.com>
Reviewed-by: Brian J Stegmiller <bjs@us.ibm.com>
Reviewed-by: Zane C Shelley <zshelle@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/88206
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
  • Loading branch information
cnpalmer authored and zane131 committed Dec 6, 2019
1 parent d65563f commit d1b5900
Show file tree
Hide file tree
Showing 12 changed files with 165 additions and 100 deletions.
5 changes: 3 additions & 2 deletions src/usr/diag/prdf/common/iipconst.h
Expand Up @@ -65,12 +65,13 @@ namespace PRDF
/* Constants */
/*--------------------------------------------------------------------*/

// Return code constants
#ifndef SUCCESS
#define SUCCESS 0
static const int32_t SUCCESS = 0;
#endif

#ifndef FAIL
#define FAIL -1
static const int32_t FAIL = -1;
#endif

enum DOMAIN_ID
Expand Down
4 changes: 2 additions & 2 deletions src/usr/diag/prdf/common/plat/prdfPlatServices_common.C
Expand Up @@ -973,7 +973,7 @@ int32_t mssGetSteerMux<TYPE_OCMB_CHIP>( TargetHandle_t i_ocmb,
{
int32_t o_rc = SUCCESS;

/* TODO RTC 207273 - sparing support
/* TODO RTC 199032 - sparing support
// called by FSP code so can't just move to hostboot side
#ifdef __HOSTBOOT_MODULE
Expand Down Expand Up @@ -1043,7 +1043,7 @@ int32_t mssSetSteerMux<TYPE_OCMB_CHIP>( TargetHandle_t i_memPort,
{
int32_t o_rc = SUCCESS;

/* TODO RTC 207273 - sparing support
/* TODO RTC 199032 - sparing support
#ifdef __HOSTBOOT_MODULE
errlHndl_t errl = NULL;
Expand Down
6 changes: 2 additions & 4 deletions src/usr/diag/prdf/plat/explorer/prdfExplorerPlugins.C
Expand Up @@ -61,12 +61,10 @@ int32_t McbistCmdComplete( ExtensibleChip * i_chip,
{
#define PRDF_FUNC "[explorer_ocmb::McbistCmdComplete] "

// TODO RTC 207273 - Do nothing for now until we have full support for
// Axone/Explorer
return SUCCESS;

// Tell the TD controller there was a command complete attention.
/*OcmbDataBundle * db = getOcmbDataBundle( i_chip );
OcmbDataBundle * db = getOcmbDataBundle( i_chip );
if ( SUCCESS != db->getTdCtlr()->handleCmdComplete(io_sc) )
{
// Something failed. It is possible the command complete attention has
Expand All @@ -79,7 +77,7 @@ int32_t McbistCmdComplete( ExtensibleChip * i_chip,
// MDIA to do it, the command complete bit has already been cleared.
// Don't do it again.
return PRD_NO_CLEAR_FIR_BITS;
}*/
}

#undef PRDF_FUNC
}
Expand Down
8 changes: 7 additions & 1 deletion src/usr/diag/prdf/plat/mem/prdfMemDsd_ipl.C
Expand Up @@ -30,6 +30,8 @@
#include <prdfMemDqBitmap.H>
#include <prdfMemDsd.H>

#include <hwp_wrappers.H>

using namespace TARGETING;

namespace PRDF
Expand Down Expand Up @@ -231,7 +233,9 @@ uint32_t DsdEvent<TYPE_OCMB_CHIP>::startCmd()

uint32_t o_rc = SUCCESS;

mss::mcbist::stop_conditions<> stopCond;
#ifdef CONFIG_AXONE

mss::mcbist::stop_conditions<mss::mc_type::EXPLORER> stopCond;

switch ( iv_phase )
{
Expand Down Expand Up @@ -260,6 +264,8 @@ uint32_t DsdEvent<TYPE_OCMB_CHIP>::startCmd()
default: PRDF_ASSERT( false ); // invalid phase
}

#endif

return o_rc;

#undef PRDF_FUNC
Expand Down
8 changes: 7 additions & 1 deletion src/usr/diag/prdf/plat/mem/prdfMemDsd_rt.C
Expand Up @@ -29,6 +29,8 @@
#include <prdfCenMbaExtraSig.H>
#include <prdfMemDsd.H>

#include <hwp_wrappers.H>

using namespace TARGETING;

namespace PRDF
Expand Down Expand Up @@ -224,7 +226,9 @@ uint32_t DsdEvent<TYPE_OCMB_CHIP>::startCmd()

uint32_t o_rc = SUCCESS;

mss::mcbist::stop_conditions<> stopCond;
#ifdef CONFIG_AXONE

mss::mcbist::stop_conditions<mss::mc_type::EXPLORER> stopCond;

stopCond.set_pause_on_ue(mss::ON);

Expand All @@ -237,6 +241,8 @@ uint32_t DsdEvent<TYPE_OCMB_CHIP>::startCmd()
iv_chip->getHuid(), getKey() );
}

#endif

return o_rc;

#undef PRDF_FUNC
Expand Down
14 changes: 12 additions & 2 deletions src/usr/diag/prdf/plat/mem/prdfMemTps_ipl.C
Expand Up @@ -36,6 +36,8 @@
#include <prdfP9McaExtraSig.H>
#include <prdfPlatServices.H>

#include <hwp_wrappers.H>

using namespace TARGETING;

namespace PRDF
Expand Down Expand Up @@ -258,13 +260,15 @@ uint32_t TpsEvent<TYPE_MCA>::startCmd()

uint32_t o_rc = SUCCESS;

#ifndef CONFIG_AXONE

// We don't need to set any stop-on-error conditions or thresholds for
// soft/inter/hard CEs during Memory Diagnostics. The design is to let the
// command continue to the end of the rank and we do diagnostics on the
// CE counts found in the per-symbol counters. Therefore, all we need to do
// is tell the hardware which CE types to count.

mss::mcbist::stop_conditions<> stopCond;
mss::mcbist::stop_conditions<mss::mc_type::NIMBUS> stopCond;

switch ( iv_phase )
{
Expand All @@ -290,6 +294,8 @@ uint32_t TpsEvent<TYPE_MCA>::startCmd()
iv_chip->getHuid(), getKey() );
}

#endif

return o_rc;

#undef PRDF_FUNC
Expand Down Expand Up @@ -381,13 +387,15 @@ uint32_t TpsEvent<TYPE_OCMB_CHIP>::startCmd()

uint32_t o_rc = SUCCESS;

#ifdef CONFIG_AXONE

// We don't need to set any stop-on-error conditions or thresholds for
// soft/inter/hard CEs during Memory Diagnostics. The design is to let the
// command continue to the end of the rank and we do diagnostics on the
// CE counts found in the per-symbol counters. Therefore, all we need to do
// is tell the hardware which CE types to count.

mss::mcbist::stop_conditions<> stopCond;
mss::mcbist::stop_conditions<mss::mc_type::EXPLORER> stopCond;

switch ( iv_phase )
{
Expand All @@ -413,6 +421,8 @@ uint32_t TpsEvent<TYPE_OCMB_CHIP>::startCmd()
iv_chip->getHuid(), getKey() );
}

#endif

return o_rc;

#undef PRDF_FUNC
Expand Down
14 changes: 12 additions & 2 deletions src/usr/diag/prdf/plat/mem/prdfMemTps_rt.C
Expand Up @@ -37,6 +37,8 @@
#include <prdfP9McaExtraSig.H>
#include <prdfTargetServices.H>

#include <hwp_wrappers.H>

using namespace TARGETING;

namespace PRDF
Expand Down Expand Up @@ -1330,13 +1332,15 @@ uint32_t TpsEvent<TYPE_MCA>::startCmd()

uint32_t o_rc = SUCCESS;

#ifndef CONFIG_AXONE

// We don't need to set any stop-on-error conditions or thresholds for
// soft/inter/hard CEs at runtime. The design is to let the command continue
// to the end of the rank and we do diagnostics on the CE counts found in
// the per-symbol counters. Therefore, all we need to do is tell the
// hardware which CE types to count.

mss::mcbist::stop_conditions<> stopCond;
mss::mcbist::stop_conditions<mss::mc_type::NIMBUS> stopCond;

switch ( iv_phase )
{
Expand Down Expand Up @@ -1364,6 +1368,8 @@ uint32_t TpsEvent<TYPE_MCA>::startCmd()
iv_chip->getHuid(), getKey() );
}

#endif

return o_rc;

#undef PRDF_FUNC
Expand All @@ -1382,13 +1388,15 @@ uint32_t TpsEvent<TYPE_OCMB_CHIP>::startCmd()

uint32_t o_rc = SUCCESS;

#ifdef CONFIG_AXONE

// We don't need to set any stop-on-error conditions or thresholds for
// soft/inter/hard CEs at runtime. The design is to let the command continue
// to the end of the rank and we do diagnostics on the CE counts found in
// the per-symbol counters. Therefore, all we need to do is tell the
// hardware which CE types to count.

mss::mcbist::stop_conditions<> stopCond;
mss::mcbist::stop_conditions<mss::mc_type::EXPLORER> stopCond;

switch ( iv_phase )
{
Expand Down Expand Up @@ -1416,6 +1424,8 @@ uint32_t TpsEvent<TYPE_OCMB_CHIP>::startCmd()
iv_chip->getHuid(), getKey() );
}

#endif

return o_rc;

#undef PRDF_FUNC
Expand Down
14 changes: 12 additions & 2 deletions src/usr/diag/prdf/plat/mem/prdfMemVcm.C
Expand Up @@ -30,6 +30,8 @@
// Platform includes
#include <prdfCenMbaExtraSig.H>

#include <hwp_wrappers.H>

using namespace TARGETING;

namespace PRDF
Expand Down Expand Up @@ -98,8 +100,10 @@ uint32_t VcmEvent<TYPE_MCA>::startCmd()

uint32_t o_rc = SUCCESS;

#ifndef CONFIG_AXONE

// No stop conditions.
mss::mcbist::stop_conditions<> stopCond;
mss::mcbist::stop_conditions<mss::mc_type::NIMBUS> stopCond;

// Start the time based scrub procedure on this master rank.
o_rc = startTdScrub<TYPE_MCA>( iv_chip, iv_rank, MASTER_RANK, stopCond );
Expand All @@ -109,6 +113,8 @@ uint32_t VcmEvent<TYPE_MCA>::startCmd()
iv_chip->getHuid(), getKey() );
}

#endif

return o_rc;

#undef PRDF_FUNC
Expand Down Expand Up @@ -475,8 +481,10 @@ uint32_t VcmEvent<TYPE_OCMB_CHIP>::startCmd()

uint32_t o_rc = SUCCESS;

#ifdef CONFIG_AXONE

// No stop conditions.
mss::mcbist::stop_conditions<> stopCond;
mss::mcbist::stop_conditions<mss::mc_type::EXPLORER> stopCond;

// Start the time based scrub procedure on this master rank.
o_rc = startTdScrub<TYPE_OCMB_CHIP>( iv_chip, iv_rank, MASTER_RANK,
Expand All @@ -487,6 +495,8 @@ uint32_t VcmEvent<TYPE_OCMB_CHIP>::startCmd()
iv_chip->getHuid(), getKey() );
}

#endif

return o_rc;

#undef PRDF_FUNC
Expand Down

0 comments on commit d1b5900

Please sign in to comment.