Skip to content

Commit

Permalink
Add initial masking to Explorer MC_OMI_FIR in exp_omi_setup
Browse files Browse the repository at this point in the history
The Explorer chip doesn't properly mask these FIRs on initialization
so we have to do it as soon as the register gets clocks

Change-Id: I7aee3fb03fa3ced342b9265862f8bc51933b4ff1
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/95244
Dev-Ready: Louis Stermole <stermole@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com>
Reviewed-by: ANDRE A MARIN <aamarin@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/95282
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com>
  • Loading branch information
stermole authored and crgeddes committed Apr 24, 2020
1 parent 09ee51c commit d97ea22
Showing 1 changed file with 5 additions and 0 deletions.
Expand Up @@ -392,6 +392,8 @@ template<>
fapi2::ReturnCode after_mc_omi_setup<mss::mc_type::EXPLORER>( const fapi2::Target<fapi2::TARGET_TYPE_OCMB_CHIP>&
i_target )
{
constexpr uint64_t MASK_ALL = ~0ull;

fapi2::buffer<uint64_t> l_dl0_error_mask;

fapi2::ReturnCode l_rc1 = fapi2::FAPI2_RC_SUCCESS;
Expand Down Expand Up @@ -435,6 +437,9 @@ fapi2::ReturnCode after_mc_omi_setup<mss::mc_type::EXPLORER>( const fapi2::Targe
.write());

// Write MC_OMI FIR register per Explorer unmask spec
// Note: Explorer doesn't initialize its DLX_MC_OMI_FIR masks to the masked state, so mask them all first
FAPI_DBG("Masking entire EXPLR_DLX_MC_OMI_FIR_MASK_REG on %s", mss::c_str(i_target));
FAPI_TRY(fapi2::putScom(i_target, EXPLR_DLX_MC_OMI_FIR_MASK_REG, MASK_ALL));
FAPI_TRY(l_exp_mc_omi_fir_reg.local_checkstop<EXPLR_DLX_MC_OMI_FIR_REG_DL0_FATAL_ERROR>()
.recoverable_error<EXPLR_DLX_MC_OMI_FIR_REG_DL0_DATA_UE>()
.recoverable_error<EXPLR_DLX_MC_OMI_FIR_REG_DL0_X4_MODE>()
Expand Down

0 comments on commit d97ea22

Please sign in to comment.