Skip to content

Commit

Permalink
errl: Mark errlogMsgHandler() as detached
Browse files Browse the repository at this point in the history
This ensures we crash if we can't process error log messages properly.
Currently the boot will just hang without any obvious reason if the task
crashes.

Change-Id: I939f720b04274ec6718690b7126db7103f9f1003
Signed-off-by: Andrew Jeffery <andrewrj@au1.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/67274
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/67526
  • Loading branch information
Andrew Jeffery authored and dcrowell77 committed Oct 17, 2018
1 parent d649d2d commit daad484
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/usr/errl/errlmanager.C
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,8 @@ void ErrlManager::errlogMsgHndlr ()
{
TRACFCOMP( g_trac_errl, ENTER_MRK "Enter ErrlManager::errlogMsgHndlr" );

task_detach();

while( 1 )
{
msg_t * theMsg = msg_wait( iv_msgQ );
Expand Down

0 comments on commit daad484

Please sign in to comment.