Skip to content

Commit

Permalink
PRD: enable MemEcc::handleMemUe() for MBA
Browse files Browse the repository at this point in the history
Change-Id: Ic7a3e38af2d9b927bfdc112a382579b459e9db3f
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/56273
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Benjamin J. Weisenbeck <bweisenb@us.ibm.com>
Reviewed-by: Caleb N. Palmer <cnpalmer@us.ibm.com>
Reviewed-by: Zane C. Shelley <zshelle@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/56894
CI-Ready: Zane C. Shelley <zshelle@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
  • Loading branch information
zane131 committed Apr 10, 2018
1 parent 2000b27 commit e772c3f
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 5 deletions.
5 changes: 4 additions & 1 deletion src/usr/diag/prdf/common/plat/mem/prdfCenMbaDataBundle.H
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
#include <prdfExtensibleChip.H>

// Platform includes
#include <prdfMemUeTable.H>
#include <prdfPlatServices.H>

#ifdef __HOSTBOOT_MODULE
Expand All @@ -51,7 +52,7 @@ class MbaDataBundle : public DataBundle
* @param i_chip The MBA chip.
*/
explicit MbaDataBundle( ExtensibleChip * i_chip ) :
iv_chip(i_chip)
iv_chip(i_chip), iv_ueTable(i_chip)
{}

/** @brief Destructor. */
Expand Down Expand Up @@ -99,6 +100,8 @@ class MbaDataBundle : public DataBundle

public: // instance variables

MemUeTable iv_ueTable; ///< UE table for FFDC

#if defined(__HOSTBOOT_MODULE) && !defined(__HOSTBOOT_RUNTIME)

/** Super fast commands during Memory Diagnostics require a cleanup after
Expand Down
7 changes: 3 additions & 4 deletions src/usr/diag/prdf/common/plat/mem/prdfMemEccAnalysis.C
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
#include <prdfMemEccAnalysis.H>

// Platform includes
#include <prdfCenMbaDataBundle.H>
#include <prdfMemAddress.H>
#include <prdfMemCaptureData.H>
#include <prdfMemDqBitmap.H>
Expand Down Expand Up @@ -137,7 +138,6 @@ uint32_t handleMemUe<TYPE_MCA>( ExtensibleChip * i_chip, const MemAddr & i_addr,
#undef PRDF_FUNC
}

/* TODO RTC 157888
template<>
uint32_t handleMemUe<TYPE_MBA>( ExtensibleChip * i_chip, const MemAddr & i_addr,
UE_TABLE::Type i_type,
Expand All @@ -146,10 +146,9 @@ uint32_t handleMemUe<TYPE_MBA>( ExtensibleChip * i_chip, const MemAddr & i_addr,
PRDF_ASSERT( nullptr != i_chip );
PRDF_ASSERT( TYPE_MBA == i_chip->getType() );

return __handleMemUe<TYPE_MBA,CenMbaDataBundle *>( i_chip, i_addr,
i_type, io_sc );
return __handleMemUe<TYPE_MBA,MbaDataBundle *>( i_chip, i_addr,
i_type, io_sc );
}
*/

//------------------------------------------------------------------------------

Expand Down
3 changes: 3 additions & 0 deletions src/usr/diag/prdf/plat/mem/prdfMemDynDealloc.C
Original file line number Diff line number Diff line change
Expand Up @@ -548,6 +548,7 @@ int32_t page( ExtensibleChip * i_chip, MemAddr i_addr )
#undef PRDF_FUNC
}
template int32_t page<TYPE_MCA>( ExtensibleChip * i_chip, MemAddr i_addr );
template int32_t page<TYPE_MBA>( ExtensibleChip * i_chip, MemAddr i_addr );

//------------------------------------------------------------------------------

Expand Down Expand Up @@ -597,6 +598,7 @@ int32_t rank( ExtensibleChip * i_chip, MemRank i_rank )
#undef PRDF_FUNC
}
template int32_t rank<TYPE_MCA>( ExtensibleChip * i_chip, MemRank i_rank );
template int32_t rank<TYPE_MBA>( ExtensibleChip * i_chip, MemRank i_rank );

//------------------------------------------------------------------------------

Expand Down Expand Up @@ -645,6 +647,7 @@ int32_t port( ExtensibleChip * i_chip )
#undef PRDF_FUNC
}
template int32_t port<TYPE_MCA>( ExtensibleChip * i_chip );
template int32_t port<TYPE_MBA>( ExtensibleChip * i_chip );

//------------------------------------------------------------------------------

Expand Down

0 comments on commit e772c3f

Please sign in to comment.