Skip to content

Commit

Permalink
Enable TCEs as the default on FSP-based systems
Browse files Browse the repository at this point in the history
This would enable TCEs on all FSP-based systems by setting the
default value of ATTR_USE_TCES_FOR_DMAS to '1'.  It can be over-
written to 0, if necessary.

Change-Id: Id30101256dfd862dae362b97b71df96def37cf03
RTC: 168745
CMVC-Prereq: 1043605
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/52549
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Stephen M. Cprek <smcprek@us.ibm.com>
Reviewed-by: Marshall J. Wilks <mjwilks@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com>
  • Loading branch information
mabaiocchi authored and Nicholas E. Bofferding committed Jan 26, 2018
1 parent d18433a commit e93cf4e
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 20 deletions.
29 changes: 12 additions & 17 deletions src/usr/isteps/istep21/call_host_runtime_setup.C
Expand Up @@ -213,9 +213,6 @@ errlHndl_t verifyAndMovePayload(void)
payload_tmp_virt_addr,
payload_size);

TRACFCOMP( ISTEPS_TRACE::g_trac_isteps_trace,
"verifyAndMovePayload(): after PAYLOAD memcpy");

// Move HDAT temporarily put into HDAT_TMP_ADDR (HDAT_TMP_SIZE) into
// its proper place
// @TODO RTC 168745 - Update hdatservices calls to return Spira-S offset
Expand Down Expand Up @@ -272,9 +269,6 @@ errlHndl_t verifyAndMovePayload(void)
hdat_tmp_virt_addr,
HDAT_TMP_SIZE);

TRACFCOMP( ISTEPS_TRACE::g_trac_isteps_trace,
"verifyAndMovePayload(): after HDAT memcpy");

} while(0);

// Handle Possible mm_block_map fails here
Expand Down Expand Up @@ -662,6 +656,18 @@ void* call_host_runtime_setup (void *io_pArgs)
}
#endif

// Fill in Hostboot runtime data for all nodes
// (adjunct partition)
// Write the HB runtime data into mainstore
l_err = RUNTIME::populate_hbRuntimeData();
if ( l_err )
{
TRACFCOMP( ISTEPS_TRACE::g_trac_isteps_trace,
"Failed hbRuntimeData setup" );
// break from do loop if error occurred
break;
}

if (TCE::utilUseTcesForDmas())
{
// Disable all TCEs
Expand All @@ -675,17 +681,6 @@ void* call_host_runtime_setup (void *io_pArgs)
}
}

// Fill in Hostboot runtime data for all nodes
// (adjunct partition)
// Write the HB runtime data into mainstore
l_err = RUNTIME::populate_hbRuntimeData();
if ( l_err )
{
TRACFCOMP( ISTEPS_TRACE::g_trac_isteps_trace,
"Failed hbRuntimeData setup" );
// break from do loop if error occurred
break;
}
} while(0);

if( l_err )
Expand Down
5 changes: 2 additions & 3 deletions src/usr/targeting/common/xmltohb/attribute_types.xml
Expand Up @@ -7464,12 +7464,11 @@ Selects which voltage level to place the Core and ECO domain PFETs upon Winkle e
</description>
<simpleType>
<uint8_t>
<default>0</default>
<default>1</default>
</uint8_t>
</simpleType>
<persistency>non-volatile</persistency>
<persistency>volatile</persistency>
<readable/>
<writeable/>
</attribute>

<attribute>
Expand Down

0 comments on commit e93cf4e

Please sign in to comment.