Skip to content

Commit

Permalink
Add in RCD attributes for DD2 debug
Browse files Browse the repository at this point in the history 
Change-Id: Ibd8e3bf3d75982fd14584fbd47b74979d515ea39
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/42090
Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Reviewed-by: Brent Wieman <bwieman@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/42133
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Dean Sanner <dsanner@us.ibm.com>
  • Loading branch information
@JacobHarvey @sannerd
JacobHarvey authored and sannerd committed Jul 11, 2017
1 parent ad62efb commit f353e9a
Show file tree
Hide file tree
Showing 11 changed files with 618 additions and 9 deletions.
109 changes: 105 additions & 4 deletions src/import/chips/p9/procedures/hwp/memory/lib/dimm/eff_dimm.C
View file
Original file line number Diff line number Diff line change
Expand Up @@ -368,10 +368,93 @@ fapi_try_exit:
return fapi2::current_err;
}

///
/// @brief Determines & sets effective config for eff_rcd_mfg_id from SPD
/// @return fapi2::FAPI2_RC_SUCCESS if okay
///
fapi2::ReturnCode eff_dimm::rcd_mfg_id()
{
uint16_t l_decoder_val = 0;
uint16_t l_mcs_attrs[PORTS_PER_MCS][MAX_DIMM_PER_PORT] = {};

/////////////////////////
// Member Method implementation
/////////////////////////
// Get & update MCS attribute
FAPI_TRY( eff_rcd_mfg_id(iv_mcs, &l_mcs_attrs[0][0]), "Failed accessing ATTR_MSS_EFF_RCD_MFG_ID" );
FAPI_TRY( iv_pDecoder->reg_manufacturer_id_code(l_decoder_val), "Failed getting rcd id code from SPD %s",
mss::c_str(iv_dimm) );

switch (l_decoder_val)
{
case fapi2::ENUM_ATTR_EFF_RCD_MFG_ID_IDT:
FAPI_INF("%s Register Manufacturer is %s", mss::c_str(iv_dimm), "IDT");
break;

case fapi2::ENUM_ATTR_EFF_RCD_MFG_ID_INPHI:
FAPI_INF("%s Register Manufacturer is %s", mss::c_str(iv_dimm), "INPHI");
break;

case fapi2::ENUM_ATTR_EFF_RCD_MFG_ID_MONTAGE:
FAPI_INF("%s Register Manufacturer is %s", mss::c_str(iv_dimm), "MONTAGE");
break;

default:
FAPI_INF("%s Register Manufacturer is 0x%04x", mss::c_str(iv_dimm), l_decoder_val);
break;
}

l_mcs_attrs[iv_port_index][iv_dimm_index] = l_decoder_val;
FAPI_TRY( FAPI_ATTR_SET(fapi2::ATTR_EFF_RCD_MFG_ID, iv_mcs, l_mcs_attrs), "Failed to set ATTR_EFF_RCD_MFG_ID" );

fapi_try_exit:
return fapi2::current_err;

}

///
/// @brief Determines & sets effective config for eff_register_type from SPD
/// @return fapi2::FAPI2_RC_SUCCESS if okay
///
fapi2::ReturnCode eff_dimm::register_type()
{
uint8_t l_decoder_val = 0;
uint8_t l_mcs_attrs[PORTS_PER_MCS][MAX_DIMM_PER_PORT] = {};

// Get & update MCS attribute
FAPI_TRY( eff_register_type(iv_mcs, &l_mcs_attrs[0][0]), "Failed accessing ATTR_MSS_REGISTER_TYPE" );
FAPI_TRY( iv_pDecoder->iv_module_decoder->register_and_buffer_type(l_decoder_val),
"Failed getting register_type code from SPD %s",
mss::c_str(iv_dimm) );

FAPI_INF("%s Register type is %s", mss::c_str(iv_dimm), l_decoder_val ? "RCD01" : "RCD02");

l_mcs_attrs[iv_port_index][iv_dimm_index] = l_decoder_val;
FAPI_TRY( FAPI_ATTR_SET(fapi2::ATTR_EFF_REGISTER_TYPE, iv_mcs, l_mcs_attrs), "Failed to set ATTR_EFF_REGISTER_TYPE" );

fapi_try_exit:
return fapi2::current_err;
}

///
/// @brief Determines & sets effective config for eff_register_rev type from SPD
/// @return fapi2::FAPI2_RC_SUCCESS if okay
///
fapi2::ReturnCode eff_dimm::register_rev()
{
uint8_t l_decoder_val = 0;
uint8_t l_mcs_attrs[PORTS_PER_MCS][MAX_DIMM_PER_PORT] = {};

// Get & update MCS attribute
FAPI_TRY( eff_register_rev(iv_mcs, &l_mcs_attrs[0][0]), "Failed accessing ATTR_MSS_REGISTER_REV" );
FAPI_TRY( iv_pDecoder->register_rev_num(l_decoder_val), "Failed getting register_rev code from SPD %s",
mss::c_str(iv_dimm) );

FAPI_INF("%s Register rev is 0x%02x", mss::c_str(iv_dimm), l_decoder_val);
l_mcs_attrs[iv_port_index][iv_dimm_index] = l_decoder_val;
FAPI_TRY( FAPI_ATTR_SET(fapi2::ATTR_EFF_REGISTER_REV, iv_mcs, l_mcs_attrs), "Failed to set ATTR_EFF_REGISTER_REV" );

fapi_try_exit:
return fapi2::current_err;

}

///
/// @brief Determines & sets effective config for eff_dram_mfg_id type from SPD
Expand All @@ -387,6 +470,25 @@ fapi2::ReturnCode eff_dimm::dram_mfg_id()
FAPI_TRY( iv_pDecoder->dram_manufacturer_id_code(l_decoder_val), "Failed getting dram id code from SPD %s",
mss::c_str(iv_dimm) );

switch (l_decoder_val)
{
case fapi2::ENUM_ATTR_EFF_DRAM_MFG_ID_MICRON:
FAPI_INF("%s Dram Manufacturer is %s", mss::c_str(iv_dimm), "MICRON");
break;

case fapi2::ENUM_ATTR_EFF_DRAM_MFG_ID_HYNIX:
FAPI_INF("%s Dram Manufacturer is %s", mss::c_str(iv_dimm), "HYNIX");
break;

case fapi2::ENUM_ATTR_EFF_DRAM_MFG_ID_SAMSUNG:
FAPI_INF("%s Dram Manufacturer is %s", mss::c_str(iv_dimm), "SAMSUNG");
break;

default:
FAPI_INF("%s Dram Manufacturer is 0x%04x", mss::c_str(iv_dimm), l_decoder_val);
break;
}

l_mcs_attrs[iv_port_index][iv_dimm_index] = l_decoder_val;
FAPI_TRY( FAPI_ATTR_SET(fapi2::ATTR_EFF_DRAM_MFG_ID, iv_mcs, l_mcs_attrs), "Failed to set ATTR_EFF_DRAM_MFG_ID" );

Expand Down Expand Up @@ -423,7 +525,6 @@ fapi2::ReturnCode eff_dimm::dram_width()

fapi_try_exit:
return fapi2::current_err;

}

///
Expand Down
19 changes: 18 additions & 1 deletion src/import/chips/p9/procedures/hwp/memory/lib/dimm/eff_dimm.H
View file
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,24 @@ class eff_dimm
///
fapi2::ReturnCode dram_mfg_id();

///
/// @brief Determines & sets effective config for eff_rcd_mfg_id type from SPD
/// @return fapi2::FAPI2_RC_SUCCESS if okay
///
fapi2::ReturnCode rcd_mfg_id();

///
/// @brief Determines & sets effective config for eff_register_type from SPD
/// @return fapi2::FAPI2_RC_SUCCESS if okay
///
fapi2::ReturnCode register_type();

///
/// @brief Determines & sets effective config for eff_register_rev type from SPD
/// @return fapi2::FAPI2_RC_SUCCESS if okay
///
fapi2::ReturnCode register_rev();

///
/// @brief Determines & sets effective config for primary stack type
/// @return fapi2::FAPI2_RC_SUCCESS if okay
Expand Down Expand Up @@ -190,7 +208,6 @@ class eff_dimm
fapi2::ReturnCode dram_density();

///

/// @brief Determines & sets effective config for dram width
/// @return fapi2::FAPI2_RC_SUCCESS if okay
///
Expand Down

0 comments on commit f353e9a

Please sign in to comment.