Skip to content

Commit

Permalink
Attach Traces to call_mss_eff_config Errors
Browse files Browse the repository at this point in the history
Attach FAPI2, EEPROM, and I2C traces to errors from the
p9_mss_eff_config HWP in call_mss_eff_config. This will
help better identify the sources of potential failures
of the HWP.

Change-Id: I2e0af1cde70ad53927a26036a2c56ff4a7878504
CQ: SW431567
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/62307
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
Ilya Smirnov authored and dcrowell77 committed Jul 16, 2018
1 parent 8dab4e1 commit f4f1896
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/usr/isteps/istep07/call_mss_eff_config.C
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
/* */
/* OpenPOWER HostBoot Project */
/* */
/* Contributors Listed Below - COPYRIGHT 2015,2017 */
/* Contributors Listed Below - COPYRIGHT 2015,2018 */
/* [+] International Business Machines Corp. */
/* */
/* */
Expand Down Expand Up @@ -60,6 +60,8 @@
#include <p9c_mss_eff_mb_interleave.H>
#include <p9c_mss_eff_config_thermal.H>

#include <hbotcompid.H>

namespace ISTEP_07
{

Expand Down Expand Up @@ -283,6 +285,8 @@ void* call_mss_eff_config( void *io_pArgs )

// Ensure istep error created and has same plid as this error
ErrlUserDetailsTarget(l_mcs_target).addToLog(l_err);
l_err->collectTrace(EEPROM_COMP_NAME);
l_err->collectTrace(I2C_COMP_NAME);
l_StepError.addErrorDetails(l_err);
errlCommit(l_err, HWPF_COMP_ID);
continue;
Expand Down

0 comments on commit f4f1896

Please sign in to comment.