Skip to content

Commit

Permalink
OCC firinit: Bug fix in reset path
Browse files Browse the repository at this point in the history
    - In reset path.. we enable OCC HB notify because when occ halts. the
interrupt should be send to PGPE. But in this path we are overwriting the
existing action register values.

Change-Id: I8825d0b237be99147afa2d477e4ac342571e9a4f
CQ:SW476322
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86994
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Gregory S Still <stillgs@us.ibm.com>
Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86996
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
  • Loading branch information
prasrang authored and dcrowell77 committed Mar 9, 2020
1 parent 42f6285 commit f79d885
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions src/import/chips/p9/procedures/hwp/pm/p9_pm_occ_firinit.C
Expand Up @@ -5,7 +5,7 @@
/* */
/* OpenPOWER HostBoot Project */
/* */
/* Contributors Listed Below - COPYRIGHT 2015,2018 */
/* Contributors Listed Below - COPYRIGHT 2015,2020 */
/* [+] International Business Machines Corp. */
/* */
/* */
Expand Down Expand Up @@ -202,11 +202,15 @@ fapi2::ReturnCode pm_occ_fir_reset(
i_target, firinit_done_flag),
"ERROR: Failed to fetch the entry status of FIRINIT");

// Here we need to read all the OCC fir registers (action0/1,mask,fir)
// and will be stored in the respective class variable. So that below when
// we call put function it will be read modify write.
FAPI_TRY(l_occFir.get(p9pmFIR::REG_ALL),
"ERROR: Failed to get the OCC FIR/MASK/ACTION0/ACTION1 value");

if (firinit_done_flag
== fapi2::ENUM_ATTR_PM_FIRINIT_DONE_ONCE_FLAG_FIRS_INITED)
{
FAPI_TRY(l_occFir.get(p9pmFIR::REG_FIRMASK),
"ERROR: Failed to get the OCC FIR MASK value");

/* Fetch the OCC FIR MASK; Save it to HWP attribute; clear its contents */
FAPI_TRY(l_occFir.saveMask(),
Expand Down

0 comments on commit f79d885

Please sign in to comment.