Skip to content

Commit

Permalink
Removed i2cSetupActiveMasters from last the IPL Step.
Browse files Browse the repository at this point in the history
The i2cSetupActiveMasters function was called during the last ipl
step in order to set the i2c bus speed to 400khz. This
functionality was determined to be redundant as the OPAL/PHYP code
initializes i2c bus speed. The call to i2cSetupActiveMasters has
been commented out for over a year.

RTC: 164492
Change-Id: I9c6a77234b15c0837768fc30e2a4f4a4da05023c
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/42290
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Prachi Gupta <pragupta@us.ibm.com>
Reviewed-by: ILYA SMIRNOV <ismirno@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
dwashbur authored and dcrowell77 committed Jun 27, 2017
1 parent 4efa113 commit f8d7535
Showing 1 changed file with 0 additions and 15 deletions.
15 changes: 0 additions & 15 deletions src/usr/isteps/istep21/call_host_start_payload.C
Original file line number Diff line number Diff line change
Expand Up @@ -317,21 +317,6 @@ errlHndl_t callShutdown ( uint64_t i_masterInstance,

}

// @todo RTC:123019 I2CM changes for P9bringup
#if (0)
// Phyp needs us to program all of the I2C masters with the bus
// divisor
TRACFCOMP( ISTEPS_TRACE::g_trac_isteps_trace,
"Setup I2C Masters" );
err = I2C::i2cSetupActiveMasters(I2C::I2C_PROC_ALL);
if( err )
{
TRACFCOMP( ISTEPS_TRACE::g_trac_isteps_trace,
"Error setting up I2C Bus Divisors" );
// just commit the error and keep going
errlCommit(err, ISTEP_COMP_ID);
}
#endif
// Get Target Service, and the system target.
TargetService& tS = targetService();
TARGETING::Target* sys = NULL;
Expand Down

0 comments on commit f8d7535

Please sign in to comment.