Remove unmask of MCBISTFIRQ[12]

This FIR bit was only used for a DD1.x workaround, and the PRD code to
handle it had already been removed from FW. We thought we would need
this FIR to implement the symbol mark performance workaround in
commit 70081 (CQ SW453101) but we didn't end up needing it. As a result
of unmasking this, there have been erroneous error logs appearing in
manufacturing tests.

Change-Id: I9ce1d563280b889609d2b0a6301ed82bd8540ba0
CQ: SW475386
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83429
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Dev-Ready: Louis Stermole <stermole@us.ibm.com>
Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com>
Reviewed-by: Mark Pizzutillo <mark.pizzutillo@ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/83435
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>

src/import/chips/p9/procedures/hwp/memory/lib/fir/unmask.C

@@ -82,8 +82,6 @@ fapi2::ReturnCode after_draminit_mc<mss::mc_type::NIMBUS>( const fapi2::Target<T
     // Broadcast mode workaround for UEs causing out of sync
     FAPI_TRY(mss::workarounds::mcbist::broadcast_out_of_sync(i_target, mss::OFF));
 
-    FAPI_TRY(mss::workarounds::mcbist::wat_debug_attention(i_target));
-
     for (const auto& p : mss::find_targets<TARGET_TYPE_MCA>(i_target))
     {
         fir::reg<MCA_FIR> l_mca_fir_reg(p, l_rc);

src/import/chips/p9/procedures/hwp/memory/lib/workarounds/mcbist_workarounds.C

@@ -146,26 +146,6 @@ fapi2::ReturnCode end_of_rank( const fapi2::Target<TARGET_TYPE_MCBIST>& i_target
     return fapi2::FAPI2_RC_SUCCESS;
 }
 
-///
-/// @brief WAT debug attention
-/// For Nimbus DD1 the MCBIST engine uses the WAT debug bit as a workaround
-/// For Nimbus DD2 the WAT debug bit is used for a different workaround
-/// @param[in] i_target the fapi2 target of the mcbist
-/// @return fapi2::ReturnCode FAPI2_RC_SUCCESS if ok
-///
-fapi2::ReturnCode wat_debug_attention( const fapi2::Target<fapi2::TARGET_TYPE_MCBIST>& i_target )
-{
-    // MCBIST attentions are already special attention
-    fapi2::ReturnCode l_rc;
-    fir::reg<MCBIST_MCBISTFIRQ> mcbist_fir_register(i_target, l_rc);
-    FAPI_TRY(l_rc, "unable to create fir::reg for %d", MCBIST_MCBISTFIRQ);
-
-    FAPI_TRY(mcbist_fir_register.attention<MCBIST_MCBISTFIRQ_WAT_DEBUG_ATTN>().write());
-
-fapi_try_exit:
-    return fapi2::current_err;
-}
-
 ///
 /// @brief BROADCAST OUT OF SYNC workaround
 /// A UE noise window is triggered by UE/AUEs causing an out of sync error

src/import/chips/p9/procedures/hwp/memory/lib/workarounds/mcbist_workarounds.H

@@ -71,14 +71,6 @@ void replace_read_helper(mss::mcbist::program<>& i_program);
 fapi2::ReturnCode end_of_rank( const fapi2::Target<fapi2::TARGET_TYPE_MCBIST>& i_target,
                                mss::mcbist::program<>& i_program );
 
-///
-/// @brief WAT debug attention
-/// For Nimbus DD1 the MCBIST engine uses the WAT debug bit as a workaround
-/// @param[in] i_target the fapi2 target of the mcbist
-/// @return fapi2::ReturnCode FAPI2_RC_SUCCESS if ok
-///
-fapi2::ReturnCode wat_debug_attention( const fapi2::Target<fapi2::TARGET_TYPE_MCBIST>& i_target );
-
 ///
 /// @brief BROADCAST OUT OF SYNC workaround
 /// A UE noise window is triggered by UE/AUEs causing an out of sync error