Skip to content

Commit

Permalink
Add check to determine if a UCD's I2C Master is functional
Browse files Browse the repository at this point in the history
Inside the code that loops over all the supported UCD devices for
possibly updating their flash image, a check was added to make
sure that the UCD's I2C Master target is functional.

Change-Id: Id03bf20f0295a27f67f9da8da207934af710630f
CQ:SW460918
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/75002
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Matthew Raybuck <matthew.raybuck@ibm.com>
Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com>
  • Loading branch information
mabaiocchi authored and Nicholas E. Bofferding committed Mar 26, 2019
1 parent ab6efc5 commit ffdc6b2
Showing 1 changed file with 15 additions and 0 deletions.
15 changes: 15 additions & 0 deletions src/usr/isteps/ucd/updateUcdFlash.C
Original file line number Diff line number Diff line change
Expand Up @@ -679,6 +679,21 @@ errlHndl_t updateAllUcdFlashImages(
"with HUID of 0x%08X",
TARGETING::get_huid(powerSequencer));

// Check that pI2cMasterTarget is functional because otherwise the UCD
// can't be accessed
TARGETING::HwasState l_hwasState =
pI2cMasterTarget->getAttr<TARGETING::ATTR_HWAS_STATE>();
if (l_hwasState.functional != true)
{
TRACFCOMP(g_trac_ucd, INFO_MRK
"updateAllUcdFlashImages: Skipping update on power sequencer HUID "
"= 0x%08X because its I2C Master HUID = 0x%08X is non-functional",
TARGETING::get_huid(powerSequencer),
TARGETING::get_huid(pI2cMasterTarget));

break;
}

const auto position = pI2cMasterTarget->
getAttr<TARGETING::ATTR_POSITION>();

Expand Down

0 comments on commit ffdc6b2

Please sign in to comment.