run build in defined locale #3354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are parts of the firmware that rely on English/C locale for some generated content, for example testfapi2.C and testfapi2_rt.C in Hostboot are created during the build and they are created incorrectly when the build runs in cs_CZ.UTF-8 locale. Signed-off-by: Dan Horák <dan@danny.cz>
|
Can one of the admins verify this patch? |
|
ok to test |
|
@oohal, do you know what's wrong with that failing p9 CI test? I can't imagine how my change could be causing it. Other PRs are passing all checks. |
Mystery op-test failure by the looks of it. |
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are parts of the firmware that rely on English/C locale for some generated
content, for example testfapi2.C and testfapi2_rt.C in Hostboot are created during
the build and they are created incorrectly when the build runs in cs_CZ.UTF-8 locale.
Signed-off-by: Dan Horák dan@danny.cz
Fixes: https://lists.ozlabs.org/pipermail/openpower-firmware/2019-December/000435.html