template.S: fix to build on architecture with non-empty __USER_LABEL_… #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PREFIX__ Blackfin has a non-empty __USER_LABEL_PREFIX__, which means that a symbol called "foo" in C must be named "_foo" in assembler. Interestingly, it seems like "$(CC) -xassembler - -c" doesn't pass the input source file through the C preprocessor, so we do this explicitly. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
|
Thanks for the suggestion @tpetazzoni, @shenki reworked this though and I believe it was fixed by 8275ca3 (template.S: fix to build on architecture with non-empty USER_LABEL_PREFIX) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…PREFIX__
Blackfin has a non-empty USER_LABEL_PREFIX, which means that a
symbol called "foo" in C must be named "_foo" in assembler.
Interestingly, it seems like "$(CC) -xassembler - -c" doesn't pass the
input source file through the C preprocessor, so we do this
explicitly.
Signed-off-by: Thomas Petazzoni thomas.petazzoni@free-electrons.com