-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for v2 signing with mlca_framework #41
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,4 +5,11 @@ create-container | |
hashkeys | ||
Makefile | ||
print-container | ||
gendilkey | ||
gendilsig | ||
verifydilsig | ||
extractdilkey | ||
bin/ | ||
*.o | ||
*.a | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
all: create-container print-container hashkeys gendilkey gendilsig verifydilsig extractdilkey | ||
|
||
create-container: create-container.c | ||
$(CC) -g -Wall -Wextra -I. $^ -o $@ -lssl -lcrypto -std=gnu99 | ||
|
||
print-container: print-container.c | ||
$(CC) -g -Wall -Wextra -I. $^ -o $@ -lssl -lcrypto -std=gnu99 -DADD_DILITHIUM -I${MLCA_PATH}/include -I${MLCA_PATH}/qsc/crystals ${MLCA_PATH}/build/libmlca2.a | ||
|
||
hashkeys: hashkeys.c | ||
$(CC) -g -Wall -Wextra -I. $^ -o $@ -lssl -lcrypto -std=gnu99 | ||
|
||
gendilkey: gendilkey.c | ||
$(CC) -g -Wall -Wextra -I. -I${MLCA_PATH}/include -I${MLCA_PATH}/qsc/crystals $^ -o $@ ${MLCA_PATH}/build/libmlca2.a -std=gnu99 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How is My expectation would be that op-build/buildroot would build the library and install it somewhere in the "host" buildroot. Then the tooling here would pick it up from some system location. It's just very weird to have a static link dependency without any documentation/information how how it is supposed to exist. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. op-build doesn't use these static makefiles it uses autoconf. And for that it doesn't use MLCA_PATH as (like you mentioned) it the MLCA library gets installed into 'host' paths so special include paths are not required. MLCA_PATH is a way to enable building when you just have both git clones side by side. |
||
|
||
gendilsig: gendilsig.c | ||
$(CC) -g -Wall -Wextra -I. -I${MLCA_PATH}/include -I${MLCA_PATH}/qsc/crystals $^ -o $@ ${MLCA_PATH}/build/libmlca2.a -std=gnu99 | ||
|
||
verifydilsig: verifydilsig.c | ||
$(CC) -g -Wall -Wextra -I. -I${MLCA_PATH}/include -I${MLCA_PATH}/qsc/crystals $^ -o $@ ${MLCA_PATH}/build/libmlca2.a -std=gnu99 | ||
|
||
extractdilkey: extractdilkey.c | ||
$(CC) -g -Wall -Wextra -I. -I${MLCA_PATH}/include -I${MLCA_PATH}/qsc/crystals $^ -o $@ ${MLCA_PATH}/build/libmlca2.a -std=gnu99 | ||
|
||
clean: | ||
$(RM) create-container print-container hashkeys gendilkey gendilsig verifydilsig extractdilkey | ||
|
||
prefix = /usr/local | ||
exec_prefix = $(prefix) | ||
bindir = $(exec_prefix)/bin | ||
|
||
install: | ||
cp create-container print-container hashkeys gendilkey gendilsig verifydilsig extractdilkey "$(bindir)" | ||
cp bulkSign.sh crtSignedContainer.sh sign-with-local-keys.sh "$(bindir)" | ||
|
||
uninstall: | ||
cd "$(bindir)" && $(RM) create-container print-container hashkeys gendilkey gendilsig verifydilsig extractdilkey | ||
cd "$(bindir)" && $(RM) bulkSign.sh crtSignedContainer.sh sign-with-local-keys.sh | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there an entirely new makefile instead of extending the existing makefile?
default
does not need to include the dilithium tools.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a simple makefile the main build process uses automake. Doing this I didn't have to take the time to figure out how to build print-container differently based on the build target