sbe: python3 build support #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables better compat between python2.7 and python3.x
Without this change, building with python3.x (python3.5 tested) as
/usr/bin/python will result in the following error:
File: "sbe/src/build/security/securityRegListGen.py", line 64
-v, --verbose enable verbose traces"
^
SyntaxError: Missing parentheses in call to 'print'
Signed-off-by: Marty E. Plummer <hanetzer@startmail.com>
io.open is compatible with python3.x's open builtin. Open in text mode (no 'b') as this is a plain csv file, and specify the encoding as utf8. Without this change, building with python3.x (python3.5 tested) as /usr/bin/python will result in the following error: File "sbe/src/build/security/securityRegListGen.py", line 695, in <module> main(sys.argv) File "sbe/src/build/security/securityRegListGen.py", line 592, in main for idx, row in enumerate(reader): File "/usr/lib/python3.5/csv.py", line 109, in __next__ self.fieldnames File "/usr/lib/python3.5/csv.py", line 96, in fieldnames self._fieldnames = next(self.reader) _csv.Error: iterator should return strings, not bytes (did you open the file in text mode?) Signed-off-by: Marty E. Plummer <hanetzer@startmail.com>
Without this change, building with python3.x (python3.5 tested) as
/usr/bin/python will result in the following error:
Traceback (most recent call last):
File "./parsAndCutElf.py", line 79, in <module>
parserElf(sys.argv)
File "./parsAndCutElf.py", line 54, in parserElf
if( (line.find(firstSection) != -1) ):
TypeError: a bytes-like object is required, not 'str'
Signed-off-by: Marty E. Plummer <hanetzer@startmail.com>
python2 returns an integer when both division operands are integers.
python3 will return a float in this situation. Use the floor division
operator (//) which returns an integer on both versions.
Without this change, building with python3.x (python3.5 tested) as
/usr/bin/python will result in the following error:
Traceback (most recent call last):
File "sbe/src/boot/sbeCompression.py", line 198, in <module>
main( sys.argv )
File "sbe/src/boot/sbeCompression.py", line 181, in main
compress(imagePath + "/" + image + ".base", imagePath + "/" + image + ".base.compressed")
File "sbe/src/boot/sbeCompression.py", line 58, in compress
for i in range(0, os.stat(inputFile).st_size / 4 ):
TypeError: 'float' object cannot be interpreted as an integer
Signed-off-by: Marty E. Plummer <hanetzer@startmail.com>
In python3.x dict.items() does (more or less) what dict.iteritems() did
in python2.x, but dict.iteritems() was removed in python3.x entirely.
Further, dict.items() in python2.7 is less efficient than dict.iteritems(),
so we attempt to use dict.iteritems(), and if that throws an AttributeError,
(which would happen on python3.x), fall back to dict.items().
Without this change, building with python3.x (python3.5 tested) as
/usr/bin/python will result in the following error:
Traceback (most recent call last):
File "sbe/src/boot/sbeCompress
ion.py", line 198, in <module>
main( sys.argv )
File "sbe/src/boot/sbeCompression.py", line 181, in main
compress(imagePath + "/" + image + ".base", imagePath + "/" + image + ".base.compressed")
File "sbe/src/boot/sbeCompression.py", line 72, in compress
sortedList = sorted(instDict.iteritems(), key=operator.itemgetter(1), reverse = True)
AttributeError: 'dict' object has no attribute 'iteritems'
Signed-off-by: Marty E. Plummer <hanetzer@startmail.com>
hanetzer
force-pushed
the
python3-for-master
branch
from
6447dbf
to
3f1224c
Compare
In python2.7, proc.stdout.read() returns a str type. On python3.x, it
returns bytes.
Without this change, building with python3.x (python3.5 tested) as
/usr/bin/python will result in the following error:
Traceback (most recent call last):
File "./updateBuildTag.py", line 76, in <module>
updateBuildTag(sys.argv)
File "./updateBuildTag.py", line 62, in updateBuildTag
cmd_build_tag = cmd_build_tag+" "+commit_id
TypeError: Can't convert 'bytes' object to str implicitly
Signed-off-by: Marty E. Plummer <hanetzer@startmail.com>
hanetzer
force-pushed
the
python3-for-master
branch
from
3f1224c
to
7506346
Compare
|
and it has been merged, thanks to all involved |
Any reason the print function stuff has not been merged? |
|
We had done the changes and will be merged with a day all print function stuff. |
|
Hi Marty, I apologise for the delayed response here. We have merged most of the stuff. It should show up in open-power/SBE now. (We have pulled in your commit into SBE-master repo which we maintain for the product and push out the same into open-power/SBE also to keep up with the sync) |
|
All commits in this pull request are merged into master, it should replicate into openpower/sbe master branch. |
|
Marty, if you see any issue, feel free to open it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings,
Been doing some tinkering with the build scripts for sbe. I lack any
hardware to test it with, so I can't say that these actually 'work', but
it has been build-tested on witherspoon_defconfig in a debian strech
chroot (I'm a gentoo user, which is part of why I've been doing this
work), using both python 2.7.13 and 3.5.3.
I think I caught all the compat issues, but I could be mistaken. I'd
really appreciate it if someone could give this a test run.