Skip to content

Commit

Permalink
MPIPL: Define OPAL metadata area
Browse files Browse the repository at this point in the history
We want to save some information (like crashing CPU PIR, kernel tags,
etc) before triggering MPIPL. Post MPIPL we will use this information
to retrieve dump metadata and create dump.

MDRT table doesn't need 64K. Hence split MDRT table to accommodate
metadata area.

Finally define metadata structure.

Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
[oliver: rebased]
Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
  • Loading branch information
Vasant Hegde authored and oohal committed Aug 15, 2019
1 parent 1ba3198 commit 4f94bda
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 1 deletion.
13 changes: 13 additions & 0 deletions core/opal-dump.c
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ static struct spira_ntuple *ntuple_mdst;
static struct spira_ntuple *ntuple_mddt;
static struct spira_ntuple *ntuple_mdrt;

static struct mpipl_metadata *mpipl_metadata;

static int opal_mpipl_add_entry(u8 region, u64 src, u64 dest, u64 size)
{
int i, max_cnt;
Expand Down Expand Up @@ -134,6 +136,17 @@ void opal_mpipl_init(void)
ntuple_mddt = &(spirah.ntuples.mdump_dst);
ntuple_mdrt = &(spirah.ntuples.mdump_res);

/* Get metadata area pointer */
mpipl_metadata = (void *)(DUMP_METADATA_AREA_BASE);

/* Clear OPAL metadata area */
if (sizeof(struct mpipl_metadata) > DUMP_METADATA_AREA_SIZE) {
prlog(PR_ERR, "INSUFFICIENT OPAL METADATA AREA\n");
prlog(PR_ERR, "INCREASE OPAL MEDTADATA AREA SIZE\n");
assert(false);
}
memset(mpipl_metadata, 0, sizeof(struct mpipl_metadata));

/* Clear MDST and MDDT table */
memset(mdst_base, 0, MDST_TABLE_SIZE);
ntuple_mdst->act_cnt = 0;
Expand Down
8 changes: 7 additions & 1 deletion include/mem-map.h
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,13 @@
* memory after moving memory content from source to destination memory.
*/
#define MDRT_TABLE_BASE (SKIBOOT_BASE + 0x01c00000)
#define MDRT_TABLE_SIZE 0x00010000
#define MDRT_TABLE_SIZE 0x00008000

/* This is our dump metadata area. We will use this memory to save metadata
* (like crashing CPU details, payload tags) before triggering MPIPL.
*/
#define DUMP_METADATA_AREA_BASE (SKIBOOT_BASE + 0x01c08000)
#define DUMP_METADATA_AREA_SIZE 0x8000

/* Total size of the above area
*
Expand Down
10 changes: 10 additions & 0 deletions include/opal-dump.h
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,16 @@ struct proc_reg_data {
uint64_t reg_val;
} __packed;

/* Metadata to capture before triggering MPIPL */
struct mpipl_metadata {
/* Crashing PIR is required to create OPAL dump */
uint32_t crashing_pir;
/* Kernel expects OPAL to presrve tag and pass it back via OPAL API */
uint64_t kernel_tag;
/* Post MPIPL kernel boot memory size */
uint64_t boot_mem_size;
} __packed;

/* init opal dump */
extern void opal_mpipl_init(void);

Expand Down

0 comments on commit 4f94bda

Please sign in to comment.