Skip to content

Commit

Permalink
phb4: Remove some unnecessary debug output
Browse files Browse the repository at this point in the history
.. and update a comment while at it.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
  • Loading branch information
ozbenh authored and stewartsmith committed Mar 16, 2017
1 parent 8b51fa4 commit 68d66bc
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions hw/phb4.c
Original file line number Diff line number Diff line change
Expand Up @@ -3034,8 +3034,6 @@ static int64_t phb4_dd1_lsi_set_xive(struct irq_source *is, uint32_t isn,
struct phb4 *p = is->data;
uint32_t idx = isn - p->base_lsi;

PHBERR(p, "DD1 LSI set_xive idx %d prio=%d\n", idx, priority);

if (idx > 8)
return OPAL_PARAMETER;

Expand All @@ -3045,16 +3043,17 @@ static int64_t phb4_dd1_lsi_set_xive(struct irq_source *is, uint32_t isn,

/* Mask using P=0,Q=1, unmask using P=1,Q=0 followed by EOI */
/* XXX FIXME: A quick mask/umask can make us shoot an interrupt
* more than once to a queue. We need to keep track better
* more than once to a queue. We need to keep track better.
*
* Thankfully, this is only on DD1 and for LSIs, so will go away
* soon enough.
*/
PHBERR(p, " LIST before: %016llx\n", in_be64(p->regs + PHB_IODA_DATA0));
if (priority == 0xff)
out_be64(p->regs + PHB_IODA_DATA0, IODA3_LIST_Q);
else {
out_be64(p->regs + PHB_IODA_DATA0, IODA3_LIST_P);
__irq_source_eoi(is, isn);
}
PHBERR(p, " LIST after: %016llx\n", in_be64(p->regs + PHB_IODA_DATA0));

phb_unlock(&p->phb);

Expand Down

0 comments on commit 68d66bc

Please sign in to comment.