Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update opal-flash-110-111-112.rst #85

Closed
wants to merge 1 commit into from
Closed

Conversation

jnider
Copy link

@jnider jnider commented Jun 20, 2017

correct typo: much -> must


This change is Reviewable

correct typo: much -> must
@ghost
Copy link

ghost commented Jun 21, 2017

Thanks so much for your patch and pull request!

One small thing I need before I can merge it though is a Signed-off-by line, as per Developer Certificate of Origin (see https://github.com/open-power/skiboot/blob/master/CONTRIBUTING.md#developer-certificate-of-origin ). This keeps a good solid audit log of where code comes from and through who (and we use it for all the same reasons as the Linux Kernel does).

A simple way to do it is "git commit --amend -s".

@jnider
Copy link
Author

jnider commented Jun 22, 2017

I signed off the patch - do I need to create a new pull request?

@ghost
Copy link

ghost commented Jun 22, 2017 via email

@ghost
Copy link

ghost commented Jul 31, 2017

I went to merge this, but I think you forgot to "git push -f" to the branch as the commit there doesn't have the 'Signed-off-by' tag in it.

@ghost ghost closed this in a491ed4 Sep 19, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant