Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HQC from PQClean #709

Closed
dstebila opened this issue Apr 7, 2020 · 3 comments · Fixed by #805
Closed

Add HQC from PQClean #709

dstebila opened this issue Apr 7, 2020 · 3 comments · Fixed by #805
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@dstebila
Copy link
Member

dstebila commented Apr 7, 2020

No description provided.

@dstebila dstebila added the enhancement New feature or request label Apr 7, 2020
@dstebila dstebila self-assigned this Apr 7, 2020
@dstebila dstebila added this to liboqs in Spring 2020 release Apr 27, 2020
@baentsch
Copy link
Member

open-quantum-safe/openssl#144 lead me to looking into also this issue -- which turned up a problem someone already has dealt with for LEDA: nistseedexpander has been (PQClean) namespaced there but not for HQC.

--> What's the reason for this? Why is this part of PQClean common, but not liboqs common? So, should this be fixed in PQClean or in liboqs?

@dstebila
Copy link
Member Author

It's not in liboqs common since, to my knowledge, we hadn't had a need for it before. Personally I'd be inclined to not have it be part of common in PQClean, since I don't think it's a primitive most crypto libraries would be expected to expose. Seems like an oversight in PQClean that there's inconsistent treatment of that primitive in LEDAcrypt versus HQC. I'd suggest we file an issue with PQClean, see which way they resolve.

@baentsch
Copy link
Member

Fine with me. Will you want to open that issue or shall I do it? Anyway, PR open-quantum-safe/openssl#177 then addresses all that can be done now on issue open-quantum-safe/openssl#144 ...

@dstebila dstebila removed this from liboqs in Spring 2020 release May 10, 2020
@dstebila dstebila added this to Algorithm updates in liboqs 0.4.0 Jul 14, 2020
@dstebila dstebila added this to the liboqs 0.4.0 RC1 milestone Jul 26, 2020
This was referenced Jul 31, 2020
@xvzcf xvzcf closed this as completed in #805 Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
liboqs 0.4.0
Algorithm updates
2 participants