Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HQC from PQClean take 2 #805

Merged
merged 4 commits into from
Aug 4, 2020
Merged

Add HQC from PQClean take 2 #805

merged 4 commits into from
Aug 4, 2020

Conversation

dstebila
Copy link
Member

@dstebila dstebila commented Aug 4, 2020

Adds HQC from PQClean. HQC makes use of nistseedexpander so this adds that as well.

Depends on #803

Replaces #804.

Fixes #709.

  • [No] Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • [Yes] Does this PR change the the list of algorithms available -- either adding or removing? (If so, PRs in OQS-OpenSSL, OQS-BoringSSL, and OQS-OpenSSH will also be required by the time this is merged.)

Note that HQC-256 variants use lots of stack space (similar to Classic McEliece). Downstream consumers will have to be updated to take this into account.

@dstebila dstebila added the enhancement New feature or request label Aug 4, 2020
@dstebila dstebila added this to the liboqs 0.4.0 RC1 milestone Aug 4, 2020
@dstebila dstebila self-assigned this Aug 4, 2020
@dstebila dstebila marked this pull request as ready for review August 4, 2020 17:17
@dstebila dstebila requested a review from xvzcf August 4, 2020 17:17
@xvzcf xvzcf merged commit adac989 into master Aug 4, 2020
@xvzcf xvzcf deleted the ds-hqc2 branch August 4, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HQC from PQClean
2 participants