Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Doxygen file #1046

Merged
merged 1 commit into from
Jul 5, 2021
Merged

Update Doxygen file #1046

merged 1 commit into from
Jul 5, 2021

Conversation

dstebila
Copy link
Member

@dstebila dstebila commented Jun 30, 2021

Fixes #1029

@dstebila dstebila requested a review from xvzcf June 30, 2021 17:00
@xvzcf
Copy link
Contributor

xvzcf commented Jul 2, 2021

The Doxygen version in openquantumsafe/ci-ubuntu-focal-x86_64:latest (used by the stylecheck CI job) is still 1.8.17, which is probably the reason for the following warnings:

warning: ignoring unsupported tag 'PYTHON_DOCSTRING' at line 236, file docs/.Doxyfile
warning: ignoring unsupported tag 'NUM_PROC_THREADS' at line 474, file docs/.Doxyfile
warning: ignoring unsupported tag 'RESOLVE_UNNAMED_PARAMS' at line 544, file docs/.Doxyfile
warning: ignoring unsupported tag 'HTML_FORMULA_FORMAT' at line 1588, file docs/.Doxyfile
warning: ignoring unsupported tag 'DOT_UML_DETAILS' at line 2417, file docs/.Doxyfile
warning: ignoring unsupported tag 'DOT_WRAP_THRESHOLD' at line 2426, file docs/.Doxyfile
warning: argument 'FAIL_ON_WARNINGS' for option WARN_AS_ERROR is not a valid boolean value
Using the default: NO!

Works fine locally on macOS though, we could merge this in and open an issue in ci-containers to track the update there?

Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI docker image now contains doxygen of this version, so warnings are no longer emitted. If the logic is OK with @xvzcf I'm surely also OK with this.

@baentsch baentsch merged commit 1009721 into main Jul 5, 2021
@baentsch baentsch deleted the doxygen-update branch July 5, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doxygen in CircleCI stylecheck job
3 participants