Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S390x support #1103

Merged
merged 2 commits into from Oct 12, 2021
Merged

S390x support #1103

merged 2 commits into from Oct 12, 2021

Conversation

bhess
Copy link
Member

@bhess bhess commented Oct 12, 2021

  • Adds build support for s390x
  • Simple CI integration with TravisCI
  • Small fix in Keccak code (unused variable on big endian architectures)
  • Small fix in FrodoKEM-SHAKE code to support big endian (see Endianness issues with BIKE #1101)
  • TravisCI build enables all algorithms except BIKE which doesn't support big endian (see Endianness issues with BIKE #1101)

Note: the generic build sets -march=z10 as default (latest architecture is z15). This is also the default and minimum architecture supported by clang. This minimum requirement ensures that there is a full-resolution clock (stckf) available for benchmarking.

Fixes #1100

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the the list of algorithms available -- either adding, removing, or renaming? (If so, PRs in OQS-OpenSSL, OQS-BoringSSL, and OQS-OpenSSH will also be required by the time this is merged.)

- Fix unused variable in Keccak code on big endian
@baentsch
Copy link
Member

Thanks for making Frodo run on the mainframe. That makes BIKE "the odd man out" and forces me to ask the question whether it'd be sensible to change our documentation as part of this PR: "Supported architectures: All" now doesn't sound right any more for BIKE.

@dstebila dstebila merged commit 0164040 into open-quantum-safe:main Oct 12, 2021
@baentsch baentsch mentioned this pull request Oct 13, 2021
@bhess
Copy link
Member Author

bhess commented Oct 13, 2021

@baentsch Thank you for the follow-up in #1104.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add s390x build
3 participants