Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable algorithm filtering #1333

Merged
merged 13 commits into from
Jan 11, 2023
Merged

Enable algorithm filtering #1333

merged 13 commits into from
Jan 11, 2023

Conversation

baentsch
Copy link
Member

@baentsch baentsch commented Dec 14, 2022

Fixes #1331

  • [ No] Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in oqs-provider, OQS-OpenSSL, OQS-BoringSSL, and OQS-OpenSSH will also need to be ready for review and merge by the time this is merged.)

@baentsch
Copy link
Member Author

@dstebila FYI, additional testing incl. AppVeyor/Windows added as discussed yesterday, so this is now ready from my side.

Copy link
Member

@dstebila dstebila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. But if we're going to change the default compilation behaviour to omit some algorithms, then I think that should also update README.md to indicate this.

@baentsch
Copy link
Member Author

Code looks good to me. But if we're going to change the default compilation behaviour to omit some algorithms, then I think that should also update README.md to indicate this.

So done in 4eb3567

@baentsch
Copy link
Member Author

Just re-considered the implications of merging this: Downstream projects must be prepared for the potential reduction of algorithms supported (or if no optimized build for some downstream projects are desired, must build liboqs with the "All/experimental algs" setting). So this PR shall not be merged before those PRs are available.

README.md Outdated Show resolved Hide resolved
baentsch and others added 2 commits December 19, 2022 07:23
Co-authored-by: Douglas Stebila <dstebila@users.noreply.github.com>
Copy link
Member Author

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops -- comment in the wrong window :-( Disregard. One more thought: Please add an explicit statement that "sntrup761" is only included until it is not needed for interop testing any more. The statement that it shall be removed if broken already is implicit in the language at https://github.com/open-quantum-safe/liboqs#limitations-and-security -- so maybe it might be suitable to add the "needed-for-interop" statement also there. Agreed, @dstebila ?
Finally, please feel free to add yourself to https://github.com/open-quantum-safe/liboqs/blob/main/CONTRIBUTORS, @ryndia

@baentsch
Copy link
Member Author

Thanks @dstebila for marking the conversation resolved. For some reason, there's still a blocking "Changes requested" marker, though... Did I overlook something?

@dstebila dstebila merged commit 9ba752e into main Jan 11, 2023
@dstebila dstebila deleted the mb-nistrecommendations branch January 11, 2023 01:29
baentsch added a commit that referenced this pull request Jan 11, 2023
@baentsch baentsch restored the mb-nistrecommendations branch January 11, 2023 06:27
dstebila pushed a commit that referenced this pull request Jan 11, 2023
@dstebila dstebila mentioned this pull request Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Algorithm enablement
3 participants