-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable algorithm filtering #1333
Conversation
@dstebila FYI, additional testing incl. AppVeyor/Windows added as discussed yesterday, so this is now ready from my side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me. But if we're going to change the default compilation behaviour to omit some algorithms, then I think that should also update README.md to indicate this.
This reverts commit 9aedf2a.
f947520
to
4eb3567
Compare
So done in 4eb3567 |
Just re-considered the implications of merging this: Downstream projects must be prepared for the potential reduction of algorithms supported (or if no optimized build for some downstream projects are desired, must build |
Co-authored-by: Douglas Stebila <dstebila@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops -- comment in the wrong window :-( Disregard. One more thought: Please add an explicit statement that "sntrup761" is only included until it is not needed for interop testing any more. The statement that it shall be removed if broken already is implicit in the language at https://github.com/open-quantum-safe/liboqs#limitations-and-security -- so maybe it might be suitable to add the "needed-for-interop" statement also there. Agreed, @dstebila ?
Finally, please feel free to add yourself to https://github.com/open-quantum-safe/liboqs/blob/main/CONTRIBUTORS, @ryndia
Thanks @dstebila for marking the conversation resolved. For some reason, there's still a blocking "Changes requested" marker, though... Did I overlook something? |
Fixes #1331